Fix SNAPSHOT ISOLATION detection in SQL Server #7555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/sql-snapshot-isolation
branch
from
29d8890
to
8fd687e
Compare
losipiuk
reviewed
Apr 11, 2021
...trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/BaseSqlServerConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
Previously we were checking the flag set with `ALTER DATABASE ... SET READ_COMMITTED_SNAPSHOT ...` instead of the one set with `ALTER DATABASE ... SET ALLOW_SNAPSHOT_ISOLATION ...`. The two flags are related, but not the same. More explanation at https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/sql/snapshot-isolation-in-sql-server#snapshot-isolation-level-extensions This also simplifies the `TestingSqlServer` setup and improves coverage of snapshot isolation tests. - `TestingSqlServer` still enables snapshot isolation by default, to avoid regular tests being flaky on CI (as in trinodb#6389). The `READ_COMMITTED_SNAPSHOT` is enabled by default as well. - dedicated tests exercise the three remaining states of the `ALLOW_SNAPSHOT_ISOLATION` and `READ_COMMITTED_SNAPSHOT` options. These tests do not leverage `BaseConnectorSmokeTest` as this could re-introduce flakiness on CI.
findepi
force-pushed
the
findepi/sql-snapshot-isolation
branch
from
8fd687e
to
9b33e49
Compare
|
CI #7559 and some related. pushed change
|
losipiuk
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were checking the flag set with
ALTER DATABASE ... SET READ_COMMITTED_SNAPSHOT ...instead of the one set withALTER DATABASE ... SET ALLOW_SNAPSHOT_ISOLATION .... The two flags are related, butnot the same. More explanation at
https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/sql/snapshot-isolation-in-sql-server#snapshot-isolation-level-extensions
This also simplifies the
TestingSqlServersetup and improves coverage of snapshot isolation tests.TestingSqlServerstill enables snapshot isolation by default, toavoid regular tests being flaky on CI (as in
Sporadic query failures due to a deadlock in SqlServerClient.getTableProperties: "Transaction was deadlocked ... and has been chosen as the deadlock victim" #6389). The
READ_COMMITTED_SNAPSHOTis enabled by default as well.ALLOW_SNAPSHOT_ISOLATIONandREAD_COMMITTED_SNAPSHOToptions.These tests do not leverage
BaseConnectorSmokeTestas this couldre-introduce flakiness on CI.
Fixes #7548