Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test TestExternalAuthenticator.testAuthenticationFromMultipleThreadsWithCachedTokenAfterAuthenticateTimesOut #7559

Closed
findepi opened this issue Apr 12, 2021 · 7 comments
Closed

Flaky test TestExternalAuthenticator.testAuthenticationFromMultipleThreadsWithCachedTokenAfterAuthenticateTimesOut #7559

findepi opened this issue Apr 12, 2021 · 7 comments
Assignees
@s2lomon
Labels
bug Something isn't working
Milestone
357

Comments

@findepi
Copy link
Member

findepi commented Apr 12, 2021

https://github.com/trinodb/trino/runs/2318804031

2021-04-11T20:52:55.7095840Z [ERROR] Tests run: 40, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.117 s <<< FAILURE! - in TestSuite
2021-04-11T20:52:55.7111879Z [ERROR] testAuthenticationFromMultipleThreadsWithCachedTokenAfterAuthenticateTimesOut(io.trino.client.auth.external.TestExternalAuthenticator)  Time elapsed: 0.029 s  <<< FAILURE!
2021-04-11T20:52:55.7120465Z org.junit.ComparisonFailure: expected:<[1]> but was:<[2]>
2021-04-11T20:52:55.7126524Z 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
2021-04-11T20:52:55.7132559Z 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
2021-04-11T20:52:55.7140268Z 	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
2021-04-11T20:52:55.7152285Z 	at io.trino.client.auth.external.TestExternalAuthenticator.testAuthenticationFromMultipleThreadsWithCachedTokenAfterAuthenticateTimesOut(TestExternalAuthenticator.java:255)
2021-04-11T20:52:55.7178546Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2021-04-11T20:52:55.7184166Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2021-04-11T20:52:55.7187160Z 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2021-04-11T20:52:55.7189163Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
2021-04-11T20:52:55.7191009Z 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
2021-04-11T20:52:55.7193390Z 	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
2021-04-11T20:52:55.7195371Z 	at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
2021-04-11T20:52:55.7197820Z 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
2021-04-11T20:52:55.7199938Z 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
2021-04-11T20:52:55.7201838Z 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
2021-04-11T20:52:55.7203838Z 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
2021-04-11T20:52:55.7205154Z 	at java.base/java.lang.Thread.run(Thread.java:834)

cc @s2lomon
@findepi findepi added the bug Something isn't working label Apr 12, 2021
@findepi findepi mentioned this issue Apr 12, 2021
Merged
@losipiuk losipiuk mentioned this issue Apr 13, 2021
Merged
@wendigo
Copy link
Contributor

wendigo commented Apr 19, 2021

https://github.com/trinodb/trino/pull/7625/checks?check_run_id=2371223686

@wendigo wendigo mentioned this issue Apr 19, 2021
Merged
@s2lomon
Copy link
Member

s2lomon commented Apr 20, 2021

I'm working on a fix, sorry for it beeing flaky in a first place.

@kokosing kokosing mentioned this issue Apr 22, 2021
Closed
@s2lomon
Copy link
Member

s2lomon commented Apr 22, 2021

#7704 that should fix it.

@findepi
Copy link
Member Author

findepi commented Apr 23, 2021

https://github.com/trinodb/trino/runs/2422619586

@findepi findepi mentioned this issue Apr 23, 2021
Merged
@findepi
Copy link
Member Author

findepi commented Apr 27, 2021

https://github.com/trinodb/trino/runs/2448389654

@findepi
Copy link
Member Author

findepi commented Apr 27, 2021

#7704 that should fix it.

where are we with that?

@findepi findepi mentioned this issue Apr 27, 2021
Merged
@kokosing
Copy link
Member

Fixed with #7704

@findepi findepi added this to the 357 milestone Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s2lomon s2lomon

Labels
bug Something isn't working
Milestone
357
Development

No branches or pull requests
4 participants
@wendigo @findepi @kokosing @s2lomon