Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projection pushdown #676

Merged
merged 3 commits into from
Jun 19, 2019
Merged

Projection pushdown #676

merged 3 commits into from
Jun 19, 2019

Conversation

martint
Copy link
Member

@martint martint commented Apr 25, 2019 •
edited
Loading

It supports basic column and row field dereference pushdown.

@cla-bot cla-bot bot added the cla-signed label Apr 25, 2019
kokosing
kokosing reviewed Apr 26, 2019
View reviewed changes
Copy link
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand with this you would be able to remove getTableLayout entirely, am I right?

presto-main/src/main/java/io/prestosql/spi/expression/ConnectorExpressionTranslator.java Outdated Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/spi/expression/ConnectorExpressionTranslator.java Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/spi/expression/ConnectorExpressionTranslator.java Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/spi/expression/ConnectorExpressionTranslator.java Outdated Show resolved Hide resolved
presto-main/src/main/java/io/prestosql/spi/expression/ConnectorExpressionTranslator.java Outdated Show resolved Hide resolved
...-main/src/main/java/io/prestosql/sql/planner/iterative/rule/PushProjectionIntoTableScan.java Show resolved Hide resolved
...-main/src/main/java/io/prestosql/sql/planner/iterative/rule/PushProjectionIntoTableScan.java Outdated Show resolved Hide resolved
presto-memory/src/main/java/io/prestosql/plugin/memory/MemoryMetadata.java Outdated Show resolved Hide resolved
presto-spi/src/main/java/io/prestosql/spi/connector/ProjectionApplicationResult.java Outdated Show resolved Hide resolved
presto-spi/src/main/java/io/prestosql/spi/connector/ProjectionApplicationResult.java
return newProjections;
}

public List<Assignment> getAssignments()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getNewAssignments?

@kokosing kokosing added WIP and removed WIP labels May 8, 2019
@martint martint mentioned this pull request May 31, 2019
Open
26 tasks
@martint martint force-pushed the projection-pushdown branch 2 times, most recently from c981e39 to 1b15a21 Compare June 10, 2019 23:51
@martint martint removed the WIP label Jun 11, 2019
@martint martint changed the title [WIP] Projection pushdown Projection pushdown Jun 11, 2019
electrum
electrum reviewed Jun 11, 2019
View reviewed changes
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have toString() on all the expression classes?

presto-spi/src/main/java/io/prestosql/spi/connector/ProjectionApplicationResult.java Outdated Show resolved Hide resolved
presto-spi/src/main/java/io/prestosql/spi/connector/ProjectionApplicationResult.java Outdated Show resolved Hide resolved
presto-spi/src/main/java/io/prestosql/spi/expression/ConnectorExpression.java Outdated Show resolved Hide resolved
presto-spi/src/main/java/io/prestosql/spi/expression/Constant.java Show resolved Hide resolved
presto-spi/src/main/java/io/prestosql/spi/expression/FieldDereference.java Outdated Show resolved Hide resolved
presto-spi/src/main/java/io/prestosql/spi/expression/ConnectorExpression.java Show resolved Hide resolved
@martint martint force-pushed the projection-pushdown branch 7 times, most recently from 40d8eb2 to ac828f9 Compare June 18, 2019 15:41
@martint
Fix default AstVisitor.visitRow implementation
bdec443 
Row is an Expression, so it should delegate to visitExpression
instead of jumping directly to visitNode
@martint
Reuse projection pushdown rules
b9dda2f
@martint
Add support for projection pushdown
5dccec2 
Add a new applyProjection API to ConnectorMetadata. Currently, simple
column references and field dereference expressions are supported.
@Praveen2112 Praveen2112 mentioned this pull request Jun 19, 2019
Closed
16 tasks
@martint martint merged commit 1afbe98 into trinodb:master Jun 19, 2019
@oneonestar oneonestar mentioned this pull request Jul 29, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopel39 sopel39 sopel39 left review comments

@electrum electrum electrum left review comments

@kokosing kokosing kokosing approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martint @electrum @sopel39 @kokosing