Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove table layouts from all connectors #781

Closed
16 tasks done
electrum opened this issue May 16, 2019 · 9 comments · Fixed by #10490
Closed
16 tasks done

Remove table layouts from all connectors #781

electrum opened this issue May 16, 2019 · 9 comments · Fixed by #10490
Milestone

Comments

@electrum
Copy link
Member

electrum commented May 16, 2019

@Praveen2112
Copy link
Member

@electrum Can I take up this issue ?

@electrum
Copy link
Member Author

electrum commented May 17, 2019

@Praveen2112 Yes, but work on one at a time, and comment here first about which one you are doing. We can have multiple people work on these in parallel. Some of these will be non-trivial or may require additional features (like column projection pushdown which is not yet implemented in the new model).

@Praveen2112
Copy link
Member

@electrum I will be starting with the Tpch and Tpcds connector

@Praveen2112
Copy link
Member

I am working on removing table layouts from Accumulo connector.

@Praveen2112
Copy link
Member

Next I am trying to remove for Atop connector.

@Praveen2112
Copy link
Member

Next I'm planning to take cassandra and raptor connector.

@Praveen2112
Copy link
Member

Once #676 is merged we can remove TableLayout for Kudu and Thrift connector

@findepi
Copy link
Member

findepi commented Mar 3, 2021

In the project i see TpchTableLayoutHandle and TpcdsTableLayoutHandle classes, so we're almost migrated.

Do we have a plan to do something with io.trino.spi.connector.ConnectorMetadata#usesLegacyTableLayouts?
It currently returns false.

Removing support for layouts would simplify things in the engine.

@martint
Copy link
Member

martint commented Mar 3, 2021

There was some issue with the TPC-DS connector due to limitations of the optimizer. @Praveen2112, do you remember?

Once those are migrated, we can just go ahead and remove the old API. It’s been almost two years since we deprecated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants