-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TableLayout API from Raptor connector #1015
Merged
electrum
merged 3 commits into
trinodb:master
from
Praveen2112:raptor_table_layout_removal
Jul 29, 2019
Merged
Remove TableLayout API from Raptor connector #1015
electrum
merged 3 commits into
trinodb:master
from
Praveen2112:raptor_table_layout_removal
Jul 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
force-pushed
the
raptor_table_layout_removal
branch
from
June 17, 2019 14:11
e639ff4
to
4bb90ef
Compare
electrum
reviewed
Jun 17, 2019
presto-raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/RaptorMetadata.java
Outdated
Show resolved
Hide resolved
presto-raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/RaptorMetadata.java
Outdated
Show resolved
Hide resolved
presto-raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/RaptorTableHandle.java
Outdated
Show resolved
Hide resolved
presto-raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/RaptorTableHandle.java
Outdated
Show resolved
Hide resolved
presto-raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/RaptorTableHandle.java
Outdated
Show resolved
Hide resolved
presto-raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/RaptorTableHandle.java
Outdated
Show resolved
Hide resolved
presto-raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/RaptorMetadata.java
Show resolved
Hide resolved
Praveen2112
force-pushed
the
raptor_table_layout_removal
branch
from
June 19, 2019 11:06
4bb90ef
to
c15568b
Compare
@electrum Have applied all the comments. Please let me know if there is any more changes. |
Praveen2112
force-pushed
the
raptor_table_layout_removal
branch
3 times, most recently
from
June 19, 2019 17:32
d80e877
to
8697cf5
Compare
electrum
approved these changes
Jul 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! It's a lot simpler than I thought it would be (compared to the Hive connector)
presto-raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/RaptorSplitManager.java
Show resolved
Hide resolved
presto-raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/RaptorTableHandle.java
Show resolved
Hide resolved
presto-raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/RaptorTableHandle.java
Show resolved
Hide resolved
presto-raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/metadata/Table.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
raptor_table_layout_removal
branch
4 times, most recently
from
July 26, 2019 07:25
07107f4
to
6bb0cfa
Compare
Praveen2112
force-pushed
the
raptor_table_layout_removal
branch
from
July 26, 2019 07:42
6bb0cfa
to
8fe80df
Compare
Merged, thanks! |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the TableLayout for Raptor connector. (#781)