Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code after ConnectorId to CatalogName renamed #639

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

guyco33
Copy link
Member

@guyco33 guyco33 commented Apr 15, 2019

Fix for #406
Solves an issue for running tests from IDE

@cla-bot cla-bot bot added the cla-signed label Apr 15, 2019
@findepi
Copy link
Member

findepi commented Apr 15, 2019

@guyco33 thanks for sending this PR.

I noticed there are more places to update. Can you search for

  • catalogName, "connectorId is null"
  • @JsonProperty("connectorId") CatalogName catalogName

in the code?

Also, please change commit title to something like

Fix code after ConnectorId to CatalogName renamed

@kokosing @electrum do you happen to know why this wasn't caught by tests?

@findepi findepi changed the title Rename ConnectorId to CatalogName - Fix for PR#406 Fix code after ConnectorId to CatalogName renamed Apr 15, 2019
@guyco33
Copy link
Member Author

guyco33 commented Apr 16, 2019

I noticed there are more places to update. Can you search for

  • catalogName, "connectorId is null"

Fixed 20 files

  • @JsonProperty("connectorId") CatalogName catalogName

Nothing else found - all fixed

in the code?

@findepi findepi merged commit 78383a9 into trinodb:master Apr 16, 2019
@findepi
Copy link
Member

findepi commented Apr 16, 2019

Merged, thanks!

@guyco33 guyco33 deleted the fix_for_PR_406 branch April 16, 2019 13:35
@findepi findepi added this to the 309 milestone Sep 25, 2019
xkrogen added a commit to xkrogen/trino that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants