Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ConnectorId to CatalogName #406

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Rename ConnectorId to CatalogName #406

merged 1 commit into from
Mar 27, 2019

Conversation

kokosing
Copy link
Member

@kokosing kokosing commented Mar 7, 2019

Rename ConnectorId to CatalogName

@cla-bot cla-bot bot added the cla-signed label Mar 7, 2019
@kokosing kokosing requested a review from electrum March 7, 2019 14:10
@kokosing kokosing force-pushed the origin/master/103_catalog_name branch 3 times, most recently from e103294 to 0ce00a8 Compare March 8, 2019 10:08
electrum
electrum approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming this is just a class rename. I didn't look at all the changes.

@electrum electrum requested a review from dain March 26, 2019 05:20
@electrum
Copy link
Member

@dain You added this class with the name ConnectorId. Is there a reason it wasn't called CatalogName?

@dain
Copy link
Member

dain commented Mar 26, 2019

@dain You added this class with the name ConnectorId. Is there a reason it wasn't called CatalogName?

In the beginning we believed that connectors did not need to know and should not know catalog name, because this gave the engine more freedom to around loading and unloading catalogs. Later we discovered that connectors need to know the catalog name for telemetry, logging, and integration with other systems. Now we believe the opposite of the original statement, connectors must know the catalog name and there is no reason to abstract it. This also means the engine is highly constrained with regard to loading and unloading catalogs.

@kokosing kokosing force-pushed the origin/master/103_catalog_name branch from 0ce00a8 to c49ad31 Compare March 27, 2019 09:59
@kokosing kokosing merged commit e27b09c into trinodb:master Mar 27, 2019
@kokosing kokosing deleted the origin/master/103_catalog_name branch March 27, 2019 12:14
@guyco33 guyco33 mentioned this pull request Apr 15, 2019
Merged
@findepi findepi mentioned this pull request Nov 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum approved these changes

@dain dain Awaiting requested review from dain

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kokosing @electrum @dain