Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pull request description template #23636

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Improve pull request description template #23636

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee5fba3
Improve pull request description template
mosabua Oct 1, 2024
1654fad
Adjust PR template to use checkbox
mosabua Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,26 @@
<!-- Thank you for submitting a pull request! Find more information in our development guide at https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md and contact us on #dev in Slack. -->
<!-- Provide an overview of the PR for maintainers and reviewers. -->
<!-- Thank you for submitting a pull request! Find more information
at https://trino.io/development/process.html,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other thing worth considering is that we could potentially change this to markdown so the links work .. but then it ends up being text that shows up in the PR after ..

Otherwise the flow you are suggesting for issues could help with links to info @wendigo

at https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md
and contact us on #core-dev in Slack. -->
<!-- Provide an overview for maintainers and reviewers. -->
## Description



<!-- Provide details that would help an engineer who is unfamiliar with this part of the code. -->
<!-- Provide details that help an engineer who is unfamiliar with this part of the code. -->
## Additional context and related issues



<!-- Mark the appropriate option with an (x). Propose a release note if you can. -->
<!-- Mark the appropriate option with an (x). Propose a release note if you can.
More info at https://trino.io/development/process#release-note -->
## Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
wendigo marked this conversation as resolved.
Show resolved Hide resolved
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

```markdown
# Section
## Section
* Fix some things. ({issue}`issuenumber`)
```