Improve pull request description template #23636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
reviewed
Oct 1, 2024
|
Okay @wendigo .. I added a second commit to change to checkboxes .. we can merge and test and potentially revert that commit. Sounds good? Looking at docs for pr templates and other info it seems to be designed for a checklist .. just not sure if it affects the PR checks and therefore status for merge |
mosabua
commented
Oct 1, 2024
| <!-- Thank you for submitting a pull request! Find more information in our development guide at https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md and contact us on #dev in Slack. --> | ||
| <!-- Provide an overview of the PR for maintainers and reviewers. --> | ||
| <!-- Thank you for submitting a pull request! Find more information | ||
| at https://trino.io/development/process.html, |
There was a problem hiding this comment.
The other thing worth considering is that we could potentially change this to markdown so the links work .. but then it ends up being text that shows up in the PR after ..
Otherwise the flow you are suggesting for issues could help with links to info @wendigo
wendigo
approved these changes
Oct 1, 2024
|
Merged now @wendigo .. let me know if this works for your next PR ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Formatted, reworded a bit, added link to process on Trino website, changed to use "core-dev" and fixed release notes suggestion.
Release notes