Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running branch for Clickhouse pushdowns #23460

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ssheikin
Copy link
Contributor

@ssheikin ssheikin commented Sep 17, 2024

Description

Smaller PRs will be chopped from this uber-PR.

TODO for varchars

Additional context and related issues

VARCHAR

PRs:

DATETIME

PRs:

ClickHouse docs:

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Contributor

@krvikash krvikash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssheikin is this PR ready for review? I see some commented out codes as well. Could you please update the description of the PR and commit message?

@ssheikin
Copy link
Contributor Author

ssheikin commented Oct 8, 2024

This is not ready to be merged, but as almost any PR it's ready for review 😉

@ssheikin ssheikin force-pushed the ssheikin/56/trino/clickhouse-pushdown branch 4 times, most recently from d726ebd to 16d241f Compare October 15, 2024 08:03
@ssheikin ssheikin force-pushed the ssheikin/56/trino/clickhouse-pushdown branch 2 times, most recently from 5ae0bf5 to f2ba3ee Compare October 15, 2024 13:27
@ssheikin ssheikin force-pushed the ssheikin/56/trino/clickhouse-pushdown branch 5 times, most recently from 79c478d to 970eda6 Compare October 15, 2024 16:39
@ssheikin ssheikin force-pushed the ssheikin/56/trino/clickhouse-pushdown branch 2 times, most recently from 680ac7f to aa0293c Compare October 16, 2024 12:38
@ssheikin ssheikin force-pushed the ssheikin/56/trino/clickhouse-pushdown branch from aa0293c to b1bc584 Compare October 16, 2024 12:50
Copy link

github-actions bot commented Nov 6, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Nov 6, 2024
@ssheikin ssheikin added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Nov 8, 2024
@ssheikin ssheikin force-pushed the ssheikin/56/trino/clickhouse-pushdown branch from b1bc584 to 50d6538 Compare November 13, 2024 13:04
@github-actions github-actions bot added the docs label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed docs hive Hive connector stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Development

Successfully merging this pull request may close these issues.

2 participants