Enable full predicate pushdown for decimal type in ClickHouse connector #21659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially resolves #7100.
This PR reworks
decimal
type support by ClickHouse connector and makes implementation similar to the one by e.g. MySQL or Postgres connectors. As the result it enables full predicate pushdown.Changes:
It's worth noting that ClickHouse implements Decimal in a slightly nuanced way (link):
Additional context and related issues
Please review previous PRs related to ClickHouse connector as the number of changes keep accumulating.
Next I'm going to focus predicate pushdown for time types and on aggregate functions.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( x) Release notes are required, with the following suggested text: