Fix listing views in Delta with Glue #19794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-with-secrets sha=511cdeabc7dbaf3187ba51cfe862899be8c8967f |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/6903034397 |
ebyhr
reviewed
Nov 20, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
.../src/test/java/io/trino/plugin/deltalake/metastore/glue/TestDeltaLakeViewsGlueMetastore.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/delta-views
branch
from
511cdea
to
9594689
Compare
findinpath
changed the title
comment parameter for views and materialized views
findepi
reviewed
Nov 20, 2023
...ino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/converter/GlueInputConverter.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/delta-views
branch
from
9594689
to
74ce6b4
Compare
|
@findepi pls consider running the PR with secrets. |
|
/test-with-secrets sha=74ce6b4b1e2a147c2afd99022d16d5811526afc6 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/6940841829 |
This is the how. "Fix listing views and materialized views in Hive/Iceberg with Glue" ? |
findepi
reviewed
Nov 21, 2023
...ino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/converter/GlueInputConverter.java
Outdated
Show resolved
Hide resolved
...ino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/converter/GlueInputConverter.java
Outdated
Show resolved
Hide resolved
...ino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/converter/GlueInputConverter.java
Outdated
Show resolved
Hide resolved
...ino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/converter/GlueInputConverter.java
Outdated
Show resolved
Hide resolved
findinpath
changed the title
comment parameter for views and materialized views
findinpath
changed the title
findinpath
force-pushed
the
findinpath/delta-views
branch
from
74ce6b4
to
56246b3
Compare
findepi
approved these changes
Nov 21, 2023
...ino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/converter/GlueInputConverter.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/delta-views
branch
from
a1e8b7a
to
ad5ed6e
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid stripping the
commentparameter for views and materialized views.Fixes #19771
Additional context and related issues
Fixes issue introduced by #19073
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: