Support altering table comments in Hive Glue catalogs #19073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Sep 18, 2023
...ino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/converter/GlueInputConverter.java
Show resolved
Hide resolved
alexjo2144
force-pushed
the
hive/glue-comments
branch
from
cac33e3
to
b9832f9
Compare
alexjo2144
changed the title
findinpath
reviewed
Sep 19, 2023
| @@ -695,7 +696,11 @@ private TableInput convertGlueTableToTableInput(com.amazonaws.services.glue.mode | |||
| @Override | |||
| public void commentTable(String databaseName, String tableName, Optional<String> comment) | |||
There was a problem hiding this comment.
Please add a test in TestHiveGlueMetastore to ensure test coverage for this new functionality.
alexjo2144
force-pushed
the
hive/glue-comments
branch
from
b9832f9
to
61bfcd5
Compare
|
Added a test |
Additionally, move the comment storage from a parameter to the description field.
findepi
force-pushed
the
hive/glue-comments
branch
from
61bfcd5
to
4e6c31e
Compare
|
( rebased ) |
findepi
approved these changes
Oct 30, 2023
|
/test-with-secrets sha=4e6c31eba052433ad3c5042bdf744e55454823eb |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/6695028096 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After this change the
descriptionfield will be used to store table comments. However legacy tables with theTABLE_COMMENTparameter will still properly display their comments.Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: