Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file based password authenticator plugin #1912

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Add file based password authenticator plugin #1912

merged 2 commits into from
Dec 6, 2019

Conversation

electrum
Copy link
Member

@electrum electrum commented Oct 31, 2019 •
edited by findepi
Loading

Supersedes #797

@cla-bot cla-bot bot added the cla-signed label Oct 31, 2019
This was referenced Oct 31, 2019
Closed
Closed
@electrum electrum requested a review from dain November 21, 2019 23:39
dain
dain approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@dain dain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but otherwise looks good

...-password-authenticators/src/main/java/io/prestosql/plugin/password/file/EncryptionUtil.java Outdated Show resolved Hide resolved
...-password-authenticators/src/main/java/io/prestosql/plugin/password/file/EncryptionUtil.java Outdated Show resolved Hide resolved
...-password-authenticators/src/main/java/io/prestosql/plugin/password/file/EncryptionUtil.java Outdated Show resolved Hide resolved
@electrum electrum closed this Dec 6, 2019
@electrum electrum deleted the password branch December 6, 2019 01:30
@electrum electrum merged commit 93cdfa0 into trinodb:master Dec 6, 2019
@tooptoop4 tooptoop4 mentioned this pull request Dec 6, 2019
Closed
@imjalpreet imjalpreet mentioned this pull request Dec 7, 2020
Merged
aweisberg pushed a commit to imjalpreet/presto that referenced this pull request Apr 9, 2021
@imjalpreet @electrum
@rupamk @aweisberg
Add file based password authenticator plugin
e111b06 
Cherry-pick of trinodb/trino#1912 (trinodb/trino#1912)

Co-authored-by: David Phillips <[email protected]>
Co-authored-by: Rupam Kundu <[email protected]>
arhimondr pushed a commit to prestodb/presto that referenced this pull request Apr 9, 2021
@imjalpreet @electrum
@rupamk @arhimondr
Add file based password authenticator plugin
c64f2a6 
Cherry-pick of trinodb/trino#1912 (trinodb/trino#1912)

Co-authored-by: David Phillips <[email protected]>
Co-authored-by: Rupam Kundu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupamk rupamk rupamk approved these changes

@dain dain dain approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@electrum @dain @rupamk