Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file based password authenticator plugin #15504

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Add file based password authenticator plugin #15504

merged 2 commits into from
Apr 9, 2021

Conversation

imjalpreet
Copy link
Member

@imjalpreet imjalpreet commented Dec 7, 2020 •
edited
Loading

Cherry-pick of trinodb/trino#1912 (trinodb/trino#1912)

Co-authored-by: David Phillips [email protected]
Co-authored-by: Rupam Kundu [email protected]

Related Issue: #15482

This PR also includes moving LDAP Authenticator to a separate package

== RELEASE NOTES ==

General Changes
* Add file based password authenticator plugin

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 7, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Jalpreet Singh Nanda (c085b6737361db43d030ec756f09a313cbf6bf50)

@dborkar
Copy link

dborkar commented Dec 8, 2020

@ashishtadose can you please take a first review?
@nezihyigitbasi @highker fyi

ashishtadose
ashishtadose reviewed Dec 8, 2020
View reviewed changes
...ssword-authenticators/src/main/java/com/facebook/presto/password/file/FileAuthenticator.java
@Inject
public FileAuthenticator(FileConfig config)
{
File file = config.getPasswordFile();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a check to validate if file exists

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashishtadose I have added the validation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@ashishtadose
Copy link
Contributor

@imjalpreet can you please also add documentation for this plugin

@ashishtadose
Copy link
Contributor

looks good to me.. can you please review it as well @highker

@aweisberg aweisberg self-requested a review April 8, 2021 14:29
aweisberg
aweisberg approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@aweisberg aweisberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thank you
Unrelated but trinodb/trino@9afb92b#diff-84dd20cc56635d89c0388d00bf9cf21cd1f50425777fdf86e9e43da69d81a94b looks like a nice refactor

@aweisberg
Copy link
Contributor

@arhimondr @rschlussel can you merge this once the tests pass? It's a pretty straightforward cherry pick.

@arhimondr arhimondr merged commit 4078f50 into prestodb:master Apr 9, 2021
@aweisberg
Copy link
Contributor

Presto accumulo didn't pass, but I don't think it is related. #15921 is showing up quite a bit now.

@rschlussel
Copy link
Contributor

I think it's the same as #15542. I haven't figured out the root cause , but it's only shown up on tests that have joins on them. In the meantime i disable the emptyJoins() test in #15898

@vaishnavibatni vaishnavibatni mentioned this pull request Apr 27, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishtadose ashishtadose ashishtadose left review comments

@aweisberg aweisberg aweisberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@imjalpreet @dborkar @ashishtadose @aweisberg @rschlussel @arhimondr