Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't start minio for Deltalake's ADLS and GCS smoke test #19098

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Don't start minio for Deltalake's ADLS and GCS smoke test #19098

merged 4 commits into from
Sep 21, 2023

Commits on Sep 19, 2023

  1. Use BlobClient.delete instead BlobClient.deleteIfExists

    @krvikash
    krvikash committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b966a59 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Use respective filesystem APIs to list and delete files for ADLS and GCS 

    MinIO is an object storage server compatible with the S3 cloud storage service.
It is not specifically designed for ABFS or GCS. To list and delete files in
ADLS and GCS, Use the respective file system APIs.
    @krvikash
    krvikash committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    23eb8a1 View commit details
    Browse the repository at this point in the history

  2. Remove the unnecessary override of listCheckpointFiles 

    Use the listFiles method and implement listCheckpointFiles
in the base class to list the checkpoint files.
    @krvikash
    krvikash committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    53c90c2 View commit details
    Browse the repository at this point in the history

  3. Don't start minio for Deltalake's ADLS and GCS smoke test 

    MinIO is an object storage server compatible with the
Amazon S3 cloud storage service. It is not specifically
designed for ABFS or GCS. It is unnecessary to start
minio container for ADLS and GCS smoke tests.
    @krvikash
    krvikash committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    faf695b View commit details
    Browse the repository at this point in the history