Don't start minio for Deltalake's ADLS and GCS smoke test #19098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests:hive
delta-lake
krvikash
requested review from
findepi,
ebyhr,
alexjo2144,
Praveen2112 and
findinpath
|
/test-with-secrets sha=10b801dd4f7526c7db5f061585beb47c062a13db |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/6244712135 |
ebyhr
reviewed
Sep 20, 2023
plugin/trino-hive/src/test/java/io/trino/plugin/hive/containers/HiveMinioDataLake.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
krvikash/delta-test-fix
branch
from
10b801d
to
3126955
Compare
|
Could you fix error-prone-checks failure? |
krvikash
force-pushed
the
krvikash/delta-test-fix
branch
from
3126955
to
4d0f846
Compare
ebyhr
approved these changes
Sep 20, 2023
...o-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeGcsConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...o-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeAwsConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
MinIO is an object storage server compatible with the S3 cloud storage service. It is not specifically designed for ABFS or GCS. To list and delete files in ADLS and GCS, Use the respective file system APIs.
Use the listFiles method and implement listCheckpointFiles in the base class to list the checkpoint files.
MinIO is an object storage server compatible with the Amazon S3 cloud storage service. It is not specifically designed for ABFS or GCS. It is unnecessary to start minio container for ADLS and GCS smoke tests.
krvikash
force-pushed
the
krvikash/delta-test-fix
branch
from
4d0f846
to
faf695b
Compare
|
Thanks, @ebyhr, Addressed comments. |
|
/test-with-secrets sha=faf695b479f15f4057746b95dc9fcfc8f13f4ec6 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/6255906273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MinIO is an object storage server compatible with the S3 cloud storage service. It is not specifically designed for ABFS or GCS. To list and delete files in ADLS and GCS, Use the respective file system APIs. It is unnecessary to start minio container for ADLS and GCS smoke tests.
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.