Update OpenTelemetry to 1.30.1 #19081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
commented
Sep 19, 2023
| // TODO: Telemetry is disabled due to NPE being thrown on null connection | ||
| // Connection connection = dataSource.getConnection(properties); | ||
| Connection connection = driver.connect(connectionUrl, properties); | ||
| Connection connection = dataSource.getConnection(properties); |
There was a problem hiding this comment.
https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/tag/v1.30.0 contains
Return default DbInfo when connection is null (open-telemetry/opentelemetry-java-instrumentation#9413)
This requires version up of dep.opentelemetry-instrumentation.version.
ebyhr
force-pushed
the
ebi/otel-1.30.0
branch
from
cb99b9d
to
32a0838
Compare
ebyhr
commented
Sep 19, 2023
| @@ -17,7 +17,7 @@ | |||
| import io.opentelemetry.api.common.Attributes; | |||
| import io.opentelemetry.api.trace.Span; | |||
| import io.opentelemetry.api.trace.StatusCode; | |||
| import io.opentelemetry.semconv.trace.attributes.SemanticAttributes; | |||
There was a problem hiding this comment.
io.opentelemetry.semconv.trace.attributes.SemanticAttributes is deprecated and caused build failure.
wendigo
approved these changes
Sep 19, 2023
|
No problem @ebyhr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.