Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable telemetry for JDBC connections #19021

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Sep 12, 2023

We've observed NPE being thrown in the codepaths where connection was not expected to be null.

Alternative to #19010

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

We've observed NPE being thrown in the codepaths where connection was not expected to be null.
@cla-bot cla-bot bot added the cla-signed label Sep 12, 2023
@wendigo wendigo requested a review from ebyhr September 12, 2023 20:44
@wendigo wendigo assigned electrum and hashhar and unassigned electrum and hashhar Sep 12, 2023
@wendigo wendigo merged commit cc82dec into trinodb:master Sep 13, 2023
59 checks passed
@wendigo wendigo deleted the serafin/disable-telemetry-jdbc branch September 13, 2023 06:35
@github-actions github-actions bot added this to the 427 milestone Sep 13, 2023
@ebyhr
Copy link
Member

ebyhr commented Sep 15, 2023

New opentelemetry-java-instrumentation is released.
https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/tag/v1.30.0

@wendigo
Copy link
Contributor Author

wendigo commented Sep 15, 2023

@ebyhr do you plan to update it?

@ebyhr
Copy link
Member

ebyhr commented Sep 19, 2023

Yes, sent #19081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants