Define separate profile for Azure cloud tests #18996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
requested review from
findepi,
electrum,
kokosing and
charlesjmorgan
losipiuk
force-pushed
the
lo/fs-tests-profiles
branch
from
a5db498
to
fc34c9d
Compare
findepi
approved these changes
Sep 11, 2023
findepi
reviewed
Sep 11, 2023
Define separate profile for Azure cloud tests to keep how we handle tests which require external infrastructure consistent in the codebase. As a consequence this drops EnabledIfEnvironmentVariable annotation. The benefit is that with expicit profile and the way how we build condition guarding if tests should be run in ci.yml (use of CI_SKIP_SECRETS_PRESENCE_CHECKS) makes it much less probable to have false confidence that we run tests, when they are skipped. With EnabledIfEnvironmentVariable we could easily skip tests if we secrets propageted to env variables were not set in github. Remaining work item is to actually fill environment variables values in ci.yml.
losipiuk
force-pushed
the
lo/fs-tests-profiles
branch
from
fc34c9d
to
0100c08
Compare
losipiuk
commented
Sep 11, 2023
| ABFS_FLAT_ACCESS_KEY: todo | ||
| ABFS_ACCOUNT: todo | ||
| ABFS_ACCESS_KEY: todo | ||
| # todo(https://github.com/trinodb/trino/issues/18998) Enable when we have env variables in place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define separate profile for Azure cloud tests to keep how we handle tests which require external infrastructure consistent in the codebase.
As a consequence this drops EnabledIfEnvironmentVariable annotation. The benefit is that with expicit profile and the way how we build condition guarding if tests should be run in ci.yml (use of CI_SKIP_SECRETS_PRESENCE_CHECKS) makes it much less probable to have false confidence that we run tests, when they are skipped. With EnabledIfEnvironmentVariable we could easily skip tests if we secrets propageted to env variables were not set in github.
Remaining work item is to actually fill environment variables values in ci.yml.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: