Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run trino-filesystem tests on Azure from CI #18998

Closed
losipiuk opened this issue Sep 11, 2023 · 1 comment · Fixed by #20967
Closed

Run trino-filesystem tests on Azure from CI #18998

losipiuk opened this issue Sep 11, 2023 · 1 comment · Fixed by #20967
Assignees
@charlesjmorgan @findinpath

Comments

@losipiuk
Copy link
Member

Currently tests are disabled as required env variables are not set in ci.yml
@losipiuk losipiuk mentioned this issue Sep 11, 2023
Merged
@charlesjmorgan charlesjmorgan self-assigned this Jan 25, 2024
@charlesjmorgan
Copy link
Member

charlesjmorgan commented Feb 20, 2024 •
edited
Loading

There are two TODOs to run the azure trino filesystem cloud tests:

  1. Add secrets to CI for the 3 abfs account kinds: blob, gen2flat, gen2hierarchical
  2. Optionally dynamically create storage accounts for each run of the azure cloud tests since it requires an empty account.
    This was already     added previously for S3

Just doing number 1 is sufficient for now. Number 2 is not needed since the azure filesystem tests are isolated per container

@charlesjmorgan charlesjmorgan mentioned this issue Mar 1, 2024
Merged
@charlesjmorgan charlesjmorgan self-assigned this Mar 1, 2024
@electrum electrum mentioned this issue Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlesjmorgan charlesjmorgan

@findinpath findinpath

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Azure native file system tests trinodb/trino
3 participants
@losipiuk @charlesjmorgan @findinpath