Iceberg minor cleanup #12767
Merged
Iceberg minor cleanup #12767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
alexjo2144
approved these changes
Jun 9, 2022
electrum
reviewed
Jun 9, 2022
| @@ -65,7 +65,8 @@ | |||
| private final Optional<DataSize> maxScannedFileSize; | |||
|
|
|||
| @JsonCreator | |||
| public IcebergTableHandle( | |||
| @Deprecated // For JSON deserialization only | |||
There was a problem hiding this comment.
Don't misuse @Deprecated like this. Name the method fromJsonForDeserializationOnly.
electrum
approved these changes
Jun 9, 2022
Don't invoke `IcebergTableHandle` constructor meant for deserialization explicitly. This fixes potential information loss in `IcebergMetadata.applyFilter` (it's believed it doesn't matter). To prevent future mistakes, the deserialization constructor is changed to a factory method.
findepi
force-pushed
the
findepi/iceberg-minor-cleanup
branch
from
a6f62e5
to
8b1a88d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #12766