Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IcebergTableHandle.enforcedPredicate coordinator-only #12766

Conversation

findepi
Copy link
Member

@findepi findepi commented Jun 9, 2022

Some minor prep for #7905 (#12362)

Don't invoke `IcebergTableHandle` constructor meant for deserialization
explicitly. This fixes potential information loss in
`IcebergMetadata.applyFilter` (it's believed it doesn't matter).

To prevent future mistakes, the deserialization constructor is changed
to a factory method.
The property is not used on workers (and shouldn't be, as it's the
enforced one). Don't send it there.
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Jun 9, 2022
@cla-bot cla-bot bot added the cla-signed label Jun 9, 2022
@findepi
Copy link
Member Author

findepi commented Jun 9, 2022

Seems like IcebergMetadata.finishUpdate is called on the coordinator, but still gets handle from serialized form.

@findepi findepi closed this Jun 9, 2022
@findepi findepi deleted the findepi/make-icebergtablehandle-enforcedpredicate-coordinator-only-7f6153 branch June 9, 2022 14:37
@findepi findepi mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

1 participant