Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate set_state for insert_state #637

Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat: deprecate set_state for insert_state #637

merged 1 commit into from
Apr 17, 2024

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Apr 17, 2024

I'm on the fence about this api churn, but this was a mistake that has been bothering me for a while, and trillium hasn't had intentional breaking changes since August 2021.

I'm going to hold off on releasing this until #611 is ready, just in case there are other easily-deprecatable changes, and then I'll stagger the releases by a week or so.

trillium/src/conn.rs Fixed Show fixed Hide fixed
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 48.83%. Comparing base (0bc2435) to head (3235c80).

Files Patch % Lines
websockets/src/websocket_connection.rs 0.00% 6 Missing ⚠️
trillium/src/conn.rs 66.66% 2 Missing ⚠️
channels/src/channel_central.rs 0.00% 1 Missing ⚠️
proxy/src/upstream/connection_counting.rs 0.00% 1 Missing ⚠️
testing/src/test_conn.rs 0.00% 1 Missing ⚠️
trillium/src/state.rs 0.00% 1 Missing ⚠️
websockets/tests/json.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   48.85%   48.83%   -0.03%     
==========================================
  Files         183      183              
  Lines        7242     7245       +3     
==========================================
  Hits         3538     3538              
- Misses       3704     3707       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbr jbr merged commit ea42ca9 into main Apr 17, 2024
9 checks passed
@jbr jbr deleted the deprecate-set-state branch April 17, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant