Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.x #611

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from
Draft

0.3.x #611

wants to merge 38 commits into from

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Apr 5, 2024

closes #565

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 75.22442% with 138 lines in your changes missing coverage. Please review.

Project coverage is 52.61%. Comparing base (8096b6a) to head (81ad587).
Report is 4 commits behind head on main.

Files Patch % Lines
http/src/conn.rs 75.53% 23 Missing ⚠️
channels/src/channel_ext.rs 0.00% 22 Missing ⚠️
client/src/conn.rs 65.45% 19 Missing ⚠️
async-std/src/server/unix.rs 52.00% 12 Missing ⚠️
http/src/headers/header_name.rs 52.63% 9 Missing ⚠️
async-std/src/runtime.rs 60.00% 8 Missing ⚠️
http/src/upgrade.rs 53.33% 7 Missing ⚠️
channels/src/channel_handler.rs 0.00% 6 Missing ⚠️
http/src/buffer.rs 54.54% 5 Missing ⚠️
api/src/error_handler.rs 0.00% 4 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   47.80%   52.61%   +4.81%     
==========================================
  Files         187      198      +11     
  Lines        7372     7534     +162     
==========================================
+ Hits         3524     3964     +440     
+ Misses       3848     3570     -278     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jbr added 7 commits May 31, 2024 13:42
as well as various other header related tidying, including improving header related test coverage
motivation: rust's tooling generally doesn't work as well with `/** */` because fewer people use it. In this case, I discovered that rustfmt's `format_code_in_doc_comments` ignores `/** */` comments. I've run into enough other bugs with `/** */` that it's time to just adopt the "normalized" uglier style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Planning: Breaking changes for trillium 0.3
1 participant