Tpetra: (local map) device default constructor fix for #11186 #11218

romintomasetti · 2022-11-02T10:37:56Z

@trilinos/Tpetra

Suggested reviewer: @brian-kelley

Motivation

Tpetra::Details::LocalMap and Tpetra::Details::FixedHashTable had no device default constructor, leading to issues when using them in a Kokkos::DualView with cuda uvm. See related issue for more information.

Related Issues

Related to Tpetra: Tpetra::Details::LocalMap cannot be default constructed on device in ROCm. #11186

Testing

We tested the patch for both cuda and rocm.

trilinos-autotester · 2022-11-02T11:52:15Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

brian-kelley · 2022-11-02T17:05:32Z

@romintomasetti If you have code lying around that you used to test this, would you mind adding it to packages/tpetra/core/test/Map/Map_LocalMap.cpp as a unit test? Just something basic that exercises a View of LocalMaps in device code.

romintomasetti · 2022-11-02T17:31:48Z

@brian-kelley I've added a test, tell me if it's ok for you ;)

brian-kelley

Thanks for adding a test. The changes look good.

I'm also watching this discussion on slack since I want to understand this behavior better. Can you hold off on merging until that's resolved, just in case there's something that needs to change?

romintomasetti · 2022-11-14T12:27:01Z

Hi @brian-kelley !
The Slack discussion was summarized in #11247.

trilinos-autotester · 2022-11-14T16:22:57Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

trilinos-autotester · 2022-11-14T16:24:56Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 1421
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

Build Num: 1416
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

Build Num: 1413
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_intel-17.0.1

Build Num: 1413
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-17.0.1-mpich-3.2-serial_release-debug_static_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_clang-10.0.0

Build Num: 1429
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-10.0.0-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_cuda-10.1.243

Build Num: 1431
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	ats2_cuda-10.1.243-gnu-8.3.1-spmpi-rolling_release_static_Volta70_Power9_no-asan_no-complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	vortex
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 1207
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 950
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Using Repos:

Repo: TRILINOS (uliegecsm/Trilinos)

Pull Request Author: romintomasetti

brian-kelley · 2022-11-14T16:25:11Z

@romintomasetti Thanks! I just marked this as inspected so that the autotester will run, and then you can merge this once it passes.

trilinos-autotester · 2022-11-14T21:04:54Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 1421
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

Build Num: 1416
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

Build Num: 1413
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_intel-17.0.1

Build Num: 1413
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-17.0.1-mpich-3.2-serial_release-debug_static_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_clang-10.0.0

Build Num: 1429
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-10.0.0-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_cuda-10.1.243

Build Num: 1431
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	ats2_cuda-10.1.243-gnu-8.3.1-spmpi-rolling_release_static_Volta70_Power9_no-asan_no-complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	vortex
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 1207
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 950
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ded0915`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2297913`

CDash Test Results for PR# 11218.

Wiki: How to Reproduce PR Testing Builds and Errors.

brian-kelley · 2022-11-14T22:45:05Z

@romintomasetti I looked at what was causing the failures and it turned out to be pretty straightforward (but likely painful to figure out if you haven't been a Trilinos developer for a long time 😄 ), so I just opened a PR against your branch here: uliegecsm#4 . With it I can build Tpetra for Cuda or Serial and all the tests pass.

The main change was just that the FixedHashTable() default constructor definition needed to go into the decl header so that it could be compiled inline in device code.

…ing them in views

trilinos-autotester · 2022-11-18T16:00:36Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

trilinos-autotester · 2022-11-18T21:07:35Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

trilinos-autotester · 2022-11-18T21:09:31Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 1446
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

Build Num: 1441
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

Build Num: 1438
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_intel-17.0.1

Build Num: 1438
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-17.0.1-mpich-3.2-serial_release-debug_static_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_clang-10.0.0

Build Num: 1454
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-10.0.0-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_cuda-10.1.243

Build Num: 1456
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	ats2_cuda-10.1.243-gnu-8.3.1-spmpi-rolling_release_static_Volta70_Power9_no-asan_no-complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	vortex
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 1232
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 975
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Using Repos:

Repo: TRILINOS (uliegecsm/Trilinos)

Pull Request Author: romintomasetti

trilinos-autotester · 2022-11-19T02:04:49Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 1446
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

Build Num: 1441
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

Build Num: 1438
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_intel-17.0.1

Build Num: 1438
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-17.0.1-mpich-3.2-serial_release-debug_static_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_clang-10.0.0

Build Num: 1454
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-10.0.0-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_cuda-10.1.243

Build Num: 1456
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	ats2_cuda-10.1.243-gnu-8.3.1-spmpi-rolling_release_static_Volta70_Power9_no-asan_no-complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	vortex
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 1232
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 975
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: Tpetra
PULLREQUESTNUM	11218
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	tpetra-local-map-constructor
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`36779cf`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`a672d98`

CDash Test Results for PR# 11218.

trilinos-autotester · 2022-11-19T02:05:07Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley ]!

trilinos-autotester · 2022-11-19T02:05:14Z

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

trilinos-autotester · 2022-11-20T02:20:28Z

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

trilinos-autotester · 2022-11-21T02:22:16Z

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

romintomasetti force-pushed the tpetra-local-map-constructor branch from 8437a66 to ded0915 Compare November 2, 2022 17:30

brian-kelley previously approved these changes Nov 2, 2022

View reviewed changes

jhux2 added the pkg: Tpetra label Nov 2, 2022

jhux2 changed the title ~~tpetra(local map): device default constructor fix for #11186~~ Tpetra: (local map) device default constructor fix for #11186 Nov 2, 2022

brian-kelley added the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Nov 14, 2022

trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Nov 14, 2022

tpetra: local map and fixed hash table device constructor to allow us…

36779cf

…ing them in views

romintomasetti dismissed brian-kelley’s stale review via 36779cf November 18, 2022 15:47

romintomasetti force-pushed the tpetra-local-map-constructor branch from ded0915 to 36779cf Compare November 18, 2022 15:47

romintomasetti mentioned this pull request Nov 18, 2022

Tpetra: minor fixes to View of LocalMap support uliegecsm/Trilinos#4

Closed

brian-kelley approved these changes Nov 18, 2022

View reviewed changes

jhux2 added the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Nov 18, 2022

trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Nov 18, 2022

brian-kelley merged commit 2e5b5ff into trilinos:develop Nov 21, 2022

maartenarnst mentioned this pull request Dec 2, 2022

Tpetra: Tpetra::Details::LocalMap cannot be default constructed on device in ROCm. #11186

Closed

csiefer2 mentioned this pull request Sep 16, 2024

Tpetra: LocalMap::KokkosView test fails to compile with UVM #13453

Open

Tpetra: (local map) device default constructor fix for #11186 #11218

Tpetra: (local map) device default constructor fix for #11186 #11218

Conversation

romintomasetti commented Nov 2, 2022

Motivation

Related Issues

Testing

trilinos-autotester commented Nov 2, 2022

brian-kelley commented Nov 2, 2022

romintomasetti commented Nov 2, 2022

brian-kelley left a comment

Choose a reason for hiding this comment

romintomasetti commented Nov 14, 2022

trilinos-autotester commented Nov 14, 2022

trilinos-autotester commented Nov 14, 2022

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-17.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-10.0.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-10.1.243

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Using Repos:

brian-kelley commented Nov 14, 2022

trilinos-autotester commented Nov 14, 2022

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-17.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-10.0.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-10.1.243

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

brian-kelley commented Nov 14, 2022

trilinos-autotester commented Nov 18, 2022

trilinos-autotester commented Nov 18, 2022

trilinos-autotester commented Nov 18, 2022

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

Jenkins Parameters

Build Information