Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpetra: LocalMap::KokkosView test fails to compile with UVM #13453

Open
csiefer2 opened this issue Sep 16, 2024 · 0 comments
Open

Tpetra: LocalMap::KokkosView test fails to compile with UVM #13453

csiefer2 opened this issue Sep 16, 2024 · 0 comments
Labels
pkg: Tpetra type: bug The primary issue is a bug in Trilinos code or tests

Comments

@csiefer2
Copy link
Member

The test introduced by @romintomasetti in #11218 does not compile in a CUDA+UVM build on the V100. @romintomasetti @brian-kelley : Any thoughts?

The error looks something like this:

Kokkos_DualView.hpp(707): error: more than one instance of overloaded function "Kokkos::deep_copy" matches the argument list:
            function template "void Tpetra::Details::deep_copy(const Kokkos::View<DT, DP...> &, const Kokkos::View<ST, SP...> &)"
            function template "void Kokkos::deep_copy(const Kokkos::View<DT, DP...> &, const Kokkos::View<ST, SP...> &, std::enable_if_t<<expression>, void> *)"
            argument types are: (Kokkos::View<Tpetra::Details::LocalMap<int, int, Kokkos::Device<Kokkos::CudaUVMSpace::execution_space, Kokkos::CudaUVMSpace::memory_space>> *, std::conditional_t<true, Kokkos::Cuda::array_layout, Kokkos::Cuda::array_layout>, Kokkos::Device<Kokkos::HostSpace::execution_space, Kokkos::Cuda::memory_space>, std::conditional_t<false, void, Kokkos::Experimental::DefaultViewHooks>>, Kokkos::View<Tpetra::Details::LocalMap<int, int, Kokkos::Device<Kokkos::CudaUVMSpace::execution_space, Kokkos::CudaUVMSpace::memory_space>> *, Kokkos::Cuda, void, void>)
          detected during:
            instantiation of "void Kokkos::DualView<DataType, Arg1Type, Arg2Type, Arg3Type>::sync_host_impl(const Args &...) [with DataType=Tpetra::Details::LocalMap<int, int, Kokkos::Device<Kokkos::CudaUVMSpace::execution_space, Kokkos::CudaUVMSpace::memory_space>> *, Arg1Type=Kokkos::Cuda, Arg2Type=void, Arg3Type=void, Args=<>]" 
(717): here
            instantiation of "void Kokkos::DualView<DataType, Arg1Type, Arg2Type, Arg3Type>::sync_host() [with DataType=Tpetra::Details::LocalMap<int, int, Kokkos::Device<Kokkos::CudaUVMSpace::execution_space, Map_LocalMap.cpp(343): here
            instantiation of "void <unnamed>::LocalMap_KokkosView_UnitTest<LO, GO, NT>::runUnitTestImpl(Teuchos::FancyOStream &, __nv_bool &) const [with LO=int, GO=int, NT=<unnamed>::Tpetra_KokkosCompat_KokkosCudaWrapperNode]" 
Map_LocalMap.cpp(363): here
@csiefer2 csiefer2 added the type: bug The primary issue is a bug in Trilinos code or tests label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: Tpetra type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

1 participant