Test and support creation of reduced Trilinos tarballs #12024
Comments
bartlettroscoe
added
the
Framework tasks
bartlettroscoe
changed the title
It appears that no Tpetra tests even use this file so why is it being copied from Anasazi_SOURCE_DIR? Well, when you create a reduced tarball with Tpetra and without Anasazi, the packages/anasazi directory does not even exist and the varaible Anasazi_SOURCE_DIR does not exist.
…rilinos#12024) This sets up a test that would have caught the problem in trilinos#11976 and will provide some protection for reduced tarball creation going forward. NOTE: Currently, this test will only be added if configure settings are passed through `-D${CMAKE_PROJECT_NAME}_CONFIGURE_OPTIONS_FILE=<cache-file>.cmake`. There is no way to pass that file (or thoses files) through `-C <cache-file>.make`.
…rilinos#12024) This sets up a test that would have caught the problem in trilinos#11976 and will provide some protection for reduced tarball creation going forward. NOTE: Currently, this test will only be added if configure settings are passed through `-D${CMAKE_PROJECT_NAME}_CONFIGURE_OPTIONS_FILE=<cache-file>.cmake`. There is no way to pass that file (or thoses files) through `-C <cache-file>.make`.
…rilinos#12024) This sets up a test that would have caught the problem in trilinos#11976 and will provide some protection for reduced tarball creation going forward. NOTE: Currently, this test will only be added if configure settings are passed through `-D${CMAKE_PROJECT_NAME}_CONFIGURE_OPTIONS_FILE=<cache-file>.cmake`. There is no way to pass that file (or thoses files) through `-C <cache-file>.make`.
…s#12024) * Now TrilinosInstallTests will be enabled if any Trilinos package gets enabled. * Removed dependence of TrilinosInstallTests on Tpetra. This should give more consistent installation testing with Trilinos. Prior to this commit, only changes to Tpetra and packages upstream from Tpetra would trigger the enable of the TrilinosInstallTests package and the running of these tests. Now, any change to any Trilinos packge will trigger some installation testing. See new TrilinosInstallTests/READMME.md file for details.
|
With the merge of PR #12044, the new test The experimental builds that show the problems are given in the following comment blocks: |
PASSED:
|
FAILED:
|
|
Below is the mail I sent to Kitware CMake experts. From: Bartlett, Roscoe A Hello Brad, Kyle, and Zack, Do you know if there is a way to determine what files were passed to CMake with the Would this need to be as CMake extension to provide the paths for these -C files? -Ross Update 7/14/2023: Below is the response from @bradking. From: Brad King On Sat, Jul 8, 2023 at 1:53 PM Bartlett, Roscoe A wrote:
I don't think we currently offer any way to get that information. We also don't currently record what If we were to add a way to get the list of files, we'd have to define semantics w.r.t. multiple runs. -Brad |
|
@sebrowne, note that the new test |
…s:develop' (4539a08). * trilinos-develop: (61 commits) EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion Panzer : Remove deprecated STK code. Fix some error message testing Remove test for removed capability More fixes for tests after source_branch removal Phalanx: add some diagnostics for checking fencing with exec spaces ...
bartlettroscoe
changed the title
bartlettroscoe
changed the title
|
@sebrowne, I would like to propose that a subset of the PR builds switch from using And just the ability to have some tests for Trilinos that configure (and optionally build) subsets of Trilinos would be very attractive. That avoids needing to add new significant infrastructure in the top level testing systems and makes it trivial for Trlinos developers to run these types of tests locally. |
…s:develop' (4539a08). * trilinos-develop: (64 commits) Phalanx: fix exec space instance init for UVM=ON SEACAS: Fix for netcdf without pnetcdf EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF IOSS: Fix bad changes from !compare to != Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion Panzer : Remove deprecated STK code. Fix some error message testing ...
…s:develop' (4539a08). * trilinos-develop: (64 commits) Phalanx: fix exec space instance init for UVM=ON SEACAS: Fix for netcdf without pnetcdf EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF IOSS: Fix bad changes from !compare to != Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion Panzer : Remove deprecated STK code. Fix some error message testing ...
…s:develop' (4539a08). * trilinos-develop: (64 commits) Phalanx: fix exec space instance init for UVM=ON SEACAS: Fix for netcdf without pnetcdf EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF IOSS: Fix bad changes from !compare to != Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion Panzer : Remove deprecated STK code. Fix some error message testing ...
…s:develop' (4539a08). * trilinos-develop: (66 commits) APREPRO: Fix -I parsing; use include_path on input file STK: Snapshot 07-17-23 09:42 from Sierra 5.15.2-314-g7c2d5cc9 Phalanx: fix exec space instance init for UVM=ON SEACAS: Fix for netcdf without pnetcdf EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF IOSS: Fix bad changes from !compare to != Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion ...
…s:develop' (4539a08). * trilinos-develop: (66 commits) APREPRO: Fix -I parsing; use include_path on input file STK: Snapshot 07-17-23 09:42 from Sierra 5.15.2-314-g7c2d5cc9 Phalanx: fix exec space instance init for UVM=ON SEACAS: Fix for netcdf without pnetcdf EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF IOSS: Fix bad changes from !compare to != Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion ...
…s:develop' (4539a08). * trilinos-develop: (66 commits) APREPRO: Fix -I parsing; use include_path on input file STK: Snapshot 07-17-23 09:42 from Sierra 5.15.2-314-g7c2d5cc9 Phalanx: fix exec space instance init for UVM=ON SEACAS: Fix for netcdf without pnetcdf EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF IOSS: Fix bad changes from !compare to != Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion ...
|
CC: @ccober6, @jwillenbring @sebrowne, as I noted two weeks ago above, the reduced tarball tests are not running in any automated testing because of the way that the GenConfig settings are passed. To see the issue, see: Trilinos/packages/TrilinosInstallTests/CMakeLists.txt Lines 129 to 133 in cb4090d Without making this change, we can't support reduced tarball creation or testing. |
|
FYI: There was an internal request for supporting reduced Trilinos tarballs for the Aleph project: I believe that use case is addressed in Trilinos 'develop' but we still don't have any PR or Nightly testing running for this. |
It appears that no Tpetra tests even use this file so why is it being copied from Anasazi_SOURCE_DIR? Well, when you create a reduced tarball with Tpetra and without Anasazi, the packages/anasazi directory does not even exist and the varaible Anasazi_SOURCE_DIR does not exist.
…rilinos#12024) This sets up a test that would have caught the problem in trilinos#11976 and will provide some protection for reduced tarball creation going forward. NOTE: Currently, this test will only be added if configure settings are passed through `-D${CMAKE_PROJECT_NAME}_CONFIGURE_OPTIONS_FILE=<cache-file>.cmake`. There is no way to pass that file (or thoses files) through `-C <cache-file>.make`.
…s#12024) * Now TrilinosInstallTests will be enabled if any Trilinos package gets enabled. * Removed dependence of TrilinosInstallTests on Tpetra. This should give more consistent installation testing with Trilinos. Prior to this commit, only changes to Tpetra and packages upstream from Tpetra would trigger the enable of the TrilinosInstallTests package and the running of these tests. Now, any change to any Trilinos packge will trigger some installation testing. See new TrilinosInstallTests/READMME.md file for details.
|
We can try making that change. The way that things are currently structured prevents us from testing it easily. I will add a story to move the SimpleTestingRefactor (or snapshot it for now) ctest driver code that is used by the PR system into the Trilinos repository. After that, it should be an easy (and testable) PR to change from the cachefile option to the TriBITS one. Although moving away from the standard cachefile import feels less than ideal to me. Better if Kitware can modify cmake to keep track of which cachefiles were loaded as described above. |
|
FYI: @sebrowne and I discussed this last week. We are going to wait until the SimpleTestingRefactor CTest -S driver code used by the Trilinos PR testing process is added to the Trilinos Git repo (so it can be tested along with PR testing) and then we will update to pass in the GenConfig *.cmake file using |
|
@sebrowne, with the merge of PR: and the completion of TRILFRAME-592, can we now pull the trigger on changing from |
|
@bartlettroscoe https://sems-atlassian-son.sandia.gov/jira/secure/RapidBoard.jspa?rapidView=164&projectKey=TRILFRAME&view=planning&selectedIssue=TRILFRAME-596&issueLimit=100 Second story on the backlog now, will do it as soon as we release 15.0. |
We need to pass -DTrilinos_CONFIGURE_OPTIONS_FILE=XXX instead of -C XXX sometimes. Decided to do it for any GCC build. User Support Ticket(s) or Story Referenced: trilinos#12024
|
This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. |
github-actions
bot
added
the
MARKED_FOR_CLOSURE
bartlettroscoe
added
DO_NOT_AUTOCLOSE
CC: @sebrowne, @ccober6, @dridzal
Description
As described in #11976, there was no testing for the creation of reduced tarballs for Trilinos as described in Creating a tarball of the source tree. But there is a desire to maintain that feature, so we need tests. Some beefier tests for reduced tarball creation was added to TriBITS proper in TriBITS PR:
However, Trilinos needs its own automated tests for reduced tarball creation (in order to avoid Trilinos-specific problems like reported in #11976).
Tasks
-C <path>/<settings>.cmaketo-D Trilinos_CONFIGURE_OPTIONS_FILE=<path>/<settings>.cmake... See belowThe text was updated successfully, but these errors were encountered: