More cleanup of packaging support (trilinos/Trilinos#11976) #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….cmake (trilinos/Trilinos#11976) I forgot to move these over when I first created TribitsPackagingSupport.cmake.
…ilinos/Trilinos#11976) The printout was not capturing the excludes added by the file CallbackDefineRepositoryPackaging.cmake. And I added a test that fails without this change.
…rilinos/Trilinos#11976) This removes a worthless warning if we are not asking for warnings. This allows the exclude of package files for Trilinos/commonTools/build_stats/ and not warn about the existing directory (so the TrilinosBuildStats package does not show up).
rabartlett1972
approved these changes
Jun 27, 2023
This was referenced Jun 28, 2023
bartlettroscoe
added a commit
to bartlettroscoe/Trilinos
that referenced
this pull request
Jul 7, 2023
…ribits-update This pulls in the new TriBITS PRs: * TriBITSPub/TriBITS#583 * TriBITSPub/TriBITS#585 * TriBITSPub/TriBITS#586 * TriBITSPub/TriBITS#587 * TriBITSPub/TriBITS#588 * TriBITSPub/TriBITS#590
4 tasks
bartlettroscoe
added a commit
to bartlettroscoe/Trilinos
that referenced
this pull request
Sep 23, 2023
…bits This brings in the following TriBITS PRs: * TriBITSPub/TriBITS#591: Allow 100% raw CMake to be used in a TriBITS-compliant package (TriBITSPub/TriBITS#582) * TriBITSPub/TriBITS#588: gitdist: Pass in '-c color.status=always' when --dist-no-color is not added * TriBITSPub/TriBITS#590: Fix: gitdist: dist-repo-status: Display tag or SHA1 instead of 'HEAD' * TriBITSPub/TriBITS#587: gitdist: dist-repo-status: Display tag or SHA1 instead of 'HEAD' * TriBITSPub/TriBITS#586: More cleanup of packaging support (trilinos#11976) This goes back to TriBITS commits from June 2023.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of a few things for packaging support (related to trilinos/Trilinos#11976).