-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure tests on different sf versions are wokring #85
Conversation
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
============================================
+ Coverage 89.15% 89.28% +0.12%
Complexity 354 354
============================================
Files 55 55
Lines 1190 1176 -14
============================================
- Hits 1061 1050 -11
+ Misses 129 126 -3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=========================================
Coverage 89.15% 89.15%
Complexity 354 354
=========================================
Files 55 55
Lines 1190 1190
=========================================
Hits 1061 1061
Misses 129 129 Continue to review full report at Codecov.
|
It's still always pulling in 4.3.2 and ignoring the version that's being set. The second call to composer update apparently does nothing - it just outputs the "Nothing to install or update" message (from what I can see from the CI). |
Yeah, Im still debugging. I think I found a solution now. I install flex globally. Waiting on travis with suspense =) |
It still doesn't work 😛 If a working solution isn't found "soon" I'll have to revert the previous PR which broke this so that we can have a working CI for other PRs. |
Hm... It works locally.. Strange. I'll keep trying for an hour or so. |
Okey, I think I know that the issue was. Since composer is in the docker image it never saw my environment variable. =) |
@@ -47,7 +47,7 @@ RUN curl --show-error https://getcomposer.org/installer | php -- \ | |||
RUN useradd -ms /bin/sh app | |||
|
|||
# Enable parallel package installation for Composer | |||
RUN su-exec app composer global require hirak/prestissimo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flex is also installing packages in parallel and it supports specifying symfony versions
Wohoo. It is working now =) |
Thank you for merging |
I made a misstake in #83.
Using
--no-scripts
will disable flex from running. In current master we are always using latest sf version.I wanted to run
--no-scripts
to avoid recipes being installed. That would add a bunch of new files that does not comply with our CS guidelines, ie build will always fail.This PR first installs flex globally. Then install all packages to the correct (lower) version. That means no recipes are installed.
I also use environment variable instad.