Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure tests on different sf versions are wokring #85

Merged
merged 6 commits into from
Jul 6, 2019

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Jul 6, 2019

I made a misstake in #83.
Using --no-scripts will disable flex from running. In current master we are always using latest sf version.
I wanted to run --no-scripts to avoid recipes being installed. That would add a bunch of new files that does not comply with our CS guidelines, ie build will always fail.

This PR first installs flex globally. Then install all packages to the correct (lower) version. That means no recipes are installed.

I also use environment variable instad.

@codecov-io
Copy link

Codecov Report

Merging #85 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #85      +/-   ##
============================================
+ Coverage     89.15%   89.28%   +0.12%     
  Complexity      354      354              
============================================
  Files            55       55              
  Lines          1190     1176      -14     
============================================
- Hits           1061     1050      -11     
+ Misses          129      126       -3
Impacted Files Coverage Δ Complexity Δ
League/Repository/RefreshTokenRepository.php 89.28% <0%> (-0.37%) 9% <0%> (ø)
League/Repository/AuthCodeRepository.php 90.32% <0%> (-0.31%) 9% <0%> (ø)
League/Repository/AccessTokenRepository.php 90.32% <0%> (-0.31%) 9% <0%> (ø)
Security/Firewall/OAuth2Listener.php 100% <0%> (ø) 7% <0%> (ø) ⬇️
Command/ClearExpiredTokensCommand.php 100% <0%> (ø) 9% <0%> (ø) ⬇️
League/Repository/UserRepository.php 100% <0%> (ø) 3% <0%> (ø) ⬇️
League/Repository/ScopeRepository.php 100% <0%> (ø) 9% <0%> (ø) ⬇️
DependencyInjection/TrikoderOAuth2Extension.php 84.25% <0%> (+1.8%) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599562c...aa9b19e. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jul 6, 2019

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #85   +/-   ##
=========================================
  Coverage     89.15%   89.15%           
  Complexity      354      354           
=========================================
  Files            55       55           
  Lines          1190     1190           
=========================================
  Hits           1061     1061           
  Misses          129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599562c...4e41e49. Read the comment docs.

@X-Coder264
Copy link
Collaborator

X-Coder264 commented Jul 6, 2019

It's still always pulling in 4.3.2 and ignoring the version that's being set. The second call to composer update apparently does nothing - it just outputs the "Nothing to install or update" message (from what I can see from the CI).

@Nyholm
Copy link
Contributor Author

Nyholm commented Jul 6, 2019

Yeah, Im still debugging. I think I found a solution now. I install flex globally.

Waiting on travis with suspense =)

@X-Coder264
Copy link
Collaborator

X-Coder264 commented Jul 6, 2019

It still doesn't work 😛

If a working solution isn't found "soon" I'll have to revert the previous PR which broke this so that we can have a working CI for other PRs.

@Nyholm
Copy link
Contributor Author

Nyholm commented Jul 6, 2019

Hm... It works locally.. Strange. I'll keep trying for an hour or so.

@Nyholm
Copy link
Contributor Author

Nyholm commented Jul 6, 2019

Okey, I think I know that the issue was. Since composer is in the docker image it never saw my environment variable. =)

@@ -47,7 +47,7 @@ RUN curl --show-error https://getcomposer.org/installer | php -- \
RUN useradd -ms /bin/sh app

# Enable parallel package installation for Composer
RUN su-exec app composer global require hirak/prestissimo
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flex is also installing packages in parallel and it supports specifying symfony versions

@Nyholm
Copy link
Contributor Author

Nyholm commented Jul 6, 2019

Wohoo. It is working now =)

@HypeMC HypeMC merged commit 8cac928 into trikoder:master Jul 6, 2019
@Nyholm
Copy link
Contributor Author

Nyholm commented Jul 6, 2019

Thank you for merging

@Nyholm Nyholm deleted the flex2 branch July 6, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants