Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EventDispatcher from SymfonyContracts #84

Merged
merged 4 commits into from
Aug 24, 2019
Merged

Use EventDispatcher from SymfonyContracts #84

merged 4 commits into from
Aug 24, 2019

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Jul 6, 2019

No description provided.

@Nyholm Nyholm changed the title WIP: Use EventDispatcher from SymfonyContracts Use EventDispatcher from SymfonyContracts Jul 6, 2019
@Nyholm
Copy link
Contributor Author

Nyholm commented Jul 6, 2019

I added a BC layer.

Dont merge this until #85 is merged and I've rebased.

@Nyholm Nyholm force-pushed the contracts branch 3 times, most recently from 0823312 to 0986d7b Compare July 6, 2019 17:38
@codecov-io
Copy link

codecov-io commented Jul 6, 2019 •
edited
Loading

Codecov Report

Merging #84 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
+ Coverage     89.24%   89.35%   +0.11%     
- Complexity      354      360       +6     
============================================
  Files            55       57       +2     
  Lines          1190     1203      +13     
============================================
+ Hits           1062     1075      +13     
  Misses          128      128
Impacted Files Coverage Δ Complexity Δ
League/Repository/ScopeRepository.php 100% <100%> (ø) 9 <0> (ø) ⬇️
League/Repository/UserRepository.php 100% <100%> (ø) 3 <0> (ø) ⬇️
Service/BCEventDispatcher.php 100% <100%> (ø) 4 <4> (?)
TrikoderOAuth2Bundle.php 100% <100%> (ø) 4 <0> (ø) ⬇️
...ction/CompilerPass/EventDispatcherCompilerPass.php 100% <100%> (ø) 2 <2> (?)
Controller/AuthorizationController.php 100% <100%> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cac928...e449381. Read the comment docs.

@Nyholm
Copy link
Contributor Author

Nyholm commented Jul 7, 2019

Rebased and ready for review

@spideyfusion spideyfusion changed the base branch from master to v2.x August 24, 2019 07:08
@spideyfusion
Copy link
Contributor

Looks good! Thanks for the contribution @Nyholm!

@spideyfusion spideyfusion merged commit 60431d4 into trikoder:v2.x Aug 24, 2019
@Nyholm Nyholm deleted the contracts branch August 24, 2019 10:00
@Nyholm
Copy link
Contributor Author

Nyholm commented Aug 24, 2019

Thank you for merging

@spideyfusion spideyfusion added this to the v2.1 milestone Dec 3, 2019
@X-Coder264 X-Coder264 mentioned this pull request Dec 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyholm @codecov-io @spideyfusion