Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Symfony deprecation helper syntax #61

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Conversation

spideyfusion
Copy link
Contributor

No description provided.

@spideyfusion spideyfusion requested a review from X-Coder264 June 3, 2019 18:12
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@a61114a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage          ?   89.51%           
  Complexity        ?      341           
=========================================
  Files             ?       52           
  Lines             ?     1145           
  Branches          ?        0           
=========================================
  Hits              ?     1025           
  Misses            ?      120           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a61114a...3bd8f46. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a61114a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage          ?   89.51%           
  Complexity        ?      341           
=========================================
  Files             ?       52           
  Lines             ?     1145           
  Branches          ?        0           
=========================================
  Hits              ?     1025           
  Misses            ?      120           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a61114a...3bd8f46. Read the comment docs.

Copy link
Collaborator

@X-Coder264 X-Coder264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I will merge this so that the CI gets unblocked (as it's the equivalent of the old value).

I'd like to propose a discussion about the long-term value of this though. Do we want to use in the long-term max[direct]= with some reasonable number that we would commit to maintaining it to be lower than that at all times? If so we should also discuss what would that "reasonable" number be 😛

@X-Coder264 X-Coder264 merged commit 82c6995 into master Jun 3, 2019
@X-Coder264 X-Coder264 deleted the deprecation-helper branch June 3, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants