Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To avoid deprecation notices #60

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Jun 3, 2019

The type "oauth2_scope" was implicitly marked as commented due to the configuration. This is deprecated and will be removed in DoctrineBundle 2.0. Either set the "commented" attribute in the configuration to "false" or mark the type as commented in "Trikoder\Bundle\OAuth2Bundle\DBAL\Type\Scope::requiresSQLCommentHint()."

@spideyfusion
Copy link
Contributor

@Nyholm I guess we'll need #61 before merging this in.

@X-Coder264
Copy link
Collaborator

@Nyholm #61 was just merged, you can rebase with master now.

@Nyholm Nyholm force-pushed the patch-deprecations branch from eb0ca96 to fa3e999 Compare June 4, 2019 06:24
@Nyholm
Copy link
Contributor Author

Nyholm commented Jun 4, 2019

pushed

@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #60 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
+ Coverage     89.51%   89.53%   +0.01%     
- Complexity      341      342       +1     
============================================
  Files            52       52              
  Lines          1145     1147       +2     
============================================
+ Hits           1025     1027       +2     
  Misses          120      120
Impacted Files Coverage Δ Complexity Δ
DBAL/Type/ImplodedArray.php 81.48% <100%> (+1.48%) 13 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c6995...fa3e999. Read the comment docs.

@X-Coder264 X-Coder264 merged commit fbde15b into trikoder:master Jun 4, 2019
@X-Coder264
Copy link
Collaborator

Thanks for the PR @Nyholm.

@Nyholm Nyholm deleted the patch-deprecations branch June 4, 2019 09:31
@Nyholm
Copy link
Contributor Author

Nyholm commented Jun 4, 2019

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants