Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix returning possible null values #184

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Conversation

dkreuer
Copy link
Contributor

@dkreuer dkreuer commented Mar 9, 2020

The function may return null values but the return type annotation restricts to return strings only. This workaround prevents PHP from crashing by returning an empty string instead - which is fine because the result is sent to output.

Supersedes PR #183 (now targets v3.x branch as it is a bugfix).

The function may return null values but the return type annotation restricts to return strings only. This workaround prevents PHP from crashing by returning an empty string instead - which is fine because the result is sent to output.
@codecov-io
Copy link

codecov-io commented Mar 9, 2020

Codecov Report

Merging #184 into v3.x will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               v3.x     #184   +/-   ##
=========================================
  Coverage     92.05%   92.05%           
  Complexity      381      381           
=========================================
  Files            56       56           
  Lines          1272     1272           
=========================================
  Hits           1171     1171           
  Misses          101      101           
Impacted Files Coverage Δ Complexity Δ
Command/ListClientsCommand.php 96.72% <100.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d65806...bbbf5ed. Read the comment docs.

@dkreuer
Copy link
Contributor Author

dkreuer commented Mar 9, 2020

Will fix the failing (added) test tomorrow.

@X-Coder264 X-Coder264 merged commit da38b7a into trikoder:v3.x Mar 12, 2020
@X-Coder264
Copy link
Collaborator

@dkreuer Thanks for the PR.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.05%. Comparing base (6d65806) to head (bbbf5ed).
Report is 87 commits behind head on v3.x.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               v3.x     #184   +/-   ##
=========================================
  Coverage     92.05%   92.05%           
  Complexity      381      381           
=========================================
  Files            56       56           
  Lines          1272     1272           
=========================================
  Hits           1171     1171           
  Misses          101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants