Merge pull request #184 from dkreuer/patch-2

Fix returning possible null values
trikoder · Mar 12, 2020 · da38b7a · da38b7a
2 parents 6d65806 + bbbf5ed
commit da38b7a
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/Command/ListClientsCommand.php b/Command/ListClientsCommand.php
@@ -115,7 +115,7 @@ private function getRows(array $clients, array $columns): array
             ];
 
             return array_map(static function (string $column) use ($values): string {
-                return $values[$column];
+                return $values[$column] ?? '';
             }, $columns);
         }, $clients);
     }

diff --git a/Tests/Acceptance/ListClientsCommandTest.php b/Tests/Acceptance/ListClientsCommandTest.php
@@ -35,6 +35,28 @@ public function testListClients(): void
         $this->assertEquals(trim($expected), trim($output));
     }
 
+    public function testListClientsWithClientHavingNoSecret(): void
+    {
+        $client = $this->fakeAClient('foobar', null);
+        $this->getClientManager()->save($client);
+
+        $command = $this->command();
+        $commandTester = new CommandTester($command);
+        $commandTester->execute([
+            'command' => $command->getName(),
+        ]);
+        $output = $commandTester->getDisplay();
+        $expected = <<<TABLE
+ ------------ -------- ------- -------------- ------------ 
+  identifier   secret   scope   redirect uri   grant type  
+ ------------ -------- ------- -------------- ------------ 
+  foobar                                                   
+ ------------ -------- ------- -------------- ------------
+TABLE;
+
+        $this->assertEquals(trim($expected), trim($output));
+    }
+
     public function testListClientsEmpty(): void
     {
         $command = $this->command();