Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml file type #710

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Add yaml file type #710

merged 1 commit into from
Mar 14, 2018

Conversation

jessica-coursera
Copy link
Contributor

@jessica-coursera jessica-coursera commented Mar 14, 2018

Fixes #705

Tested locally to confirm that it works

@arturi

@arturi
Copy link
Contributor

arturi commented Mar 14, 2018

Thank you!

I guess we should extend this list with more file types / extensions. We are also thinking of getting rid of fileType detection using https://github.com/sindresorhus/file-type, since its making file adding async and slow, complicating things.

@arturi arturi merged commit fc818ac into transloadit:master Mar 14, 2018
@jessica-coursera
Copy link
Contributor Author

jessica-coursera commented Mar 15, 2018

@arturi do you mind bumping the version so I can pick up these changes on npm? thanks! :)
not super urgent, but maybe within the next week or so

@jessica-coursera jessica-coursera mentioned this pull request Mar 21, 2018
@arturi
Copy link
Contributor

arturi commented Mar 22, 2018

Done!

@arturi arturi mentioned this pull request May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants