New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YAML file type #705

Closed

jessica-coursera opened this issue Mar 13, 2018 · 1 comment

Assignees

Labels

Contributor

jessica-coursera commented Mar 13, 2018 •

edited

Loading

Hello!
I'm trying to upload a yaml file with Uppy, but fileType ends up being null so it errors out. I'm guessing this is because https://github.com/sindresorhus/file-type doesn't support yaml.
I think adding the lines 'yaml': 'text/yaml' and 'yml': 'text/yaml' to https://github.com/transloadit/uppy/blob/master/src/core/Utils.js#L119 should work. If someone could add that, that'd be great! Or if someone can just confirm that that's correct, I can create a PR for it.

The text was updated successfully, but these errors were encountered:

Contributor

arturi commented Mar 14, 2018

Hi! Yes, seems like that should fix it, I’ve confirmed in local tests. Please send the PR! 🙏

arturi self-assigned this

arturi added the Improvement label

jessica-coursera mentioned this issue

Add yaml file type #710

Merged

arturi closed this as completed in #710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment