Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checkbox for screenreaders 2 #2980

Merged
merged 12 commits into from
Jul 9, 2021
Merged

Improve checkbox for screenreaders 2 #2980

merged 12 commits into from
Jul 9, 2021

Conversation

arturi
Copy link
Contributor

@arturi arturi commented Jul 1, 2021

This is a new PR from the same branch #2930, restored after Artur merged Merlijn’s PR too soon

We noticed, when navigating via keyboard and using a screen reader, the screen reader does not tell the user when they have checked one of the boxes next to a file or folder. It will tell them the state of the checkbox when it first gains focus, but pressing enter or the spacebar to check or uncheck the box does not result in any screen reader feedback.

  • Improves checkboxes for screenreaders by using an actual input element with the right attributes.
  • Fix eslint warnings

Before

  • Focus on checkbox of folder: "Select all files from folder This is shared, selected (1 of 2)"
    • Clicked: Nothing happens. When re-focussing: "Unselect all files from folder This is shared, selected (1 of 2)"
  • Focus on folder: "Open folder This is shared, button"
  • Focus on checkbox of file: "Select file some file name.docx, some file.docx , selected (2 of 2)". Notice the double file name.
    • Clicked: Nothing happens. When re-focussing: "Unselect file some file name.docx, some file.docx , selected (2 of 2)"

After

  • Focus on checkbox of folder: "unticked, all files from folder This is Shared, checkbox (1 of 2)". No need for select/unselect.
    • Clicked: "ticked, all files from folder This is Shared, checkbox (1 of 2)"
  • Focus on folder: "Open folder This is shared, button (1 of 2)"
  • Focus on checkbox of file: "unticked, some file name.docx, checkbox (2 of 2)"
    • Clicked: "ticked, some file name.docx, checkbox (2 of 2)"

Murderlon and others added 6 commits June 15, 2021 12:35
Co-authored-by: Antoine du Hamel <[email protected]>
* 2.0:
  tus: remove `autoRetry` option (#2938)
  dashboard: set default trigger: null (#2942)
  locales: remove es_GL that was kept for backwards-compat (#2943)
  xhr: change default name depending on whether `bundle` is set (#2933)
  Upgrade Preact to latest (#2926)
  temporarily add cheerio-select-tmp to devDependencies to fix tests
  #2920 fixed standalone server to initiate itself on explicit function… (#2924)
  Update BACKLOG.md
  Google drive shortcuts (#2917)
  Update BACKLOG.md
  Allowed HTML Attributes to be passed via props (#2891)
  Expose drag-drop events (#2914)
@Murderlon Murderlon changed the base branch from master to 2.0 July 1, 2021 08:17
@Murderlon Murderlon self-assigned this Jul 1, 2021
Murderlon added 4 commits July 8, 2021 11:58
* 2.0: (80 commits)
  Update BACKLOG.md
  tools: lint JS code snippets inside blog posts (#2992)
  Change concurrent file upload limit to 5 in tus and xhr-upload (#2993)
  deps: revert back to `^`
  @uppy/companion: fix build
  deps: remove unused `cheerio-select-tmp`
  Add instagram development notes (#2984)
  tools: fix linter errors in JS code snippets inside blog posts (#2991)
  deps: remove unused `karma-*`
  deps: update `browserify` to v17
  deps: upgrade eslint plugins
  deps: upgrade `adm-zip` to v0.5
  deps: upgrade `typescript` version
  deps: upgrade `verdaccio` to v5
  deps: upgrade `tsd` to v0.17
  deps: update `temp-write` to v5
  deps: upgrade `tar` to v6
  deps: upgrade `remark-cli` to v9
  deps: upgrade `pacote` to v11
  deps: upgrade `onchange` to v7
  ...
…nto checkbox-a11y

* 'checkbox-a11y' of https://github.com/transloadit/uppy:
  Fix order in English locale
  Update French locale
  Remove redundant aria attributes
@Murderlon Murderlon marked this pull request as ready for review July 8, 2021 14:21
Murderlon added 2 commits July 9, 2021 10:42
* 2.0:
  @uppy/angular: upgrade to Angular 12.1
  core: fix types
  core: force `new` keyword (#2949)
  showLinkToFileUploadResult: false by default (#2994)
  companion: Remove deprecated serverHeaders in favour of companionHeaders (#2995)
  deprecate multipleResults option (#2996)
@arturi arturi merged commit e78722e into 2.0 Jul 9, 2021
@arturi arturi deleted the checkbox-a11y branch July 9, 2021 23:17
Murderlon added a commit that referenced this pull request Jul 20, 2021
* 2.0: (78 commits)
  build: remove `@babel/polyfill` in favor of `core-js@3` (#3025)
  ci: update Webdriverio packages (#3027)
  Fix lint warnings in bin/locale-packs.js (#3028)
  doc, deps: clean up polyfill inconsistencies (#3020)
  core: remove more IE hacks (#3015)
  core: remove use of `Array.prototype.reduce` where possible (#3016)
  @uppy/image-editor: fix SASS deprecation warning (#3009)
  tools: remove use of `promisify` where possible (#3010)
  test: fix end2end test suite (#3008)
  tools: enable linter for TypeScript (#2997)
  Update BACKLOG.md
  @uppy/store-redux: force `new` keyword
  Improve checkbox for screenreaders 2 (#2980)
  @uppy/angular: upgrade to Angular 12.1
  core: fix types
  core: force `new` keyword (#2949)
  showLinkToFileUploadResult: false by default (#2994)
  companion: Remove deprecated serverHeaders in favour of companionHeaders (#2995)
  deprecate multipleResults option (#2996)
  tools: lint JS code snippets inside blog posts (#2992)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants