tus: remove autoRetry option
#2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturi
reviewed
Jun 16, 2021
| }).toThrowError(/The `autoRetry` option was deprecated and has been removed/) | ||
| }) | ||
|
|
||
| it('Throws errors if autoRetry option is `undefined`', () => { |
There was a problem hiding this comment.
It’s probably not hurting, but not sure we need tests for a deprecation warning, since we’ll remove it in the future :) Not a problem, just thinking out loud about how we should approach this in the future.
There was a problem hiding this comment.
My thinking was having tests would help with the code review, I agree such tests doesn't bring a lot of value. Do you want me to remove them?
There was a problem hiding this comment.
We can keep them since they are already made but perhaps choose not to make tests like this again for deprecation warnings in the future
Murderlon
added a commit
that referenced
this pull request
Jul 8, 2021
* 2.0: tus: remove `autoRetry` option (#2938) dashboard: set default trigger: null (#2942) locales: remove es_GL that was kept for backwards-compat (#2943) xhr: change default name depending on whether `bundle` is set (#2933) Upgrade Preact to latest (#2926) temporarily add cheerio-select-tmp to devDependencies to fix tests #2920 fixed standalone server to initiate itself on explicit function… (#2924) Update BACKLOG.md Google drive shortcuts (#2917) Update BACKLOG.md Allowed HTML Attributes to be passed via props (#2891) Expose drag-drop events (#2914)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.