FEATURE: Timeout option for ImageOptim. #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toy Please review :) Thank you! |
tgxworld
force-pushed
the
global_timeout
branch
5 times, most recently
from
378cd9f to
8390d62
Compare
|
Not sure what is going on with appveyor here
|
|
I'm also not sure what is with appveyor, but can be ignored till merging. As I understand you wanted to change worker timeout in #149 to image optimisation timeout as in this PR. I think it is better to already think about possibility of both options. Maybe Do I understand right that you want timeout exception to lead to abort of cli? I think |
I'm only looking to implement a global timeout for image optim.
Yup it should abort the CLI as well :) |
oblakeerickson
added a commit
to oblakeerickson/image_optim
that referenced
this pull request
Oct 23, 2020
This PR addresses the feedback what was originally given on PR toy#162 by adding a default worker specific timeout option in addition to a global timeout. The original commit discourse@8bf3c0e on PR toy#162 with just the global timeout has been in production since 2018-07-08 on Discourse instances using a forked version of this gem. We would like to get this change merged in, so that we can get off of the discourse specific fork and use the latest version of the image_optim gem. Co-authored-by: Blake Erickson <[email protected]>
oblakeerickson
pushed a commit
to oblakeerickson/image_optim
that referenced
this pull request
Dec 4, 2020
This PR addresses the feedback what was originally given on PR toy#162 by adding a default worker specific timeout option in addition to a global timeout. The original commit discourse@8bf3c0e on PR toy#162 with just the global timeout has been in production since 2018-07-08 on Discourse instances using a forked version of this gem. We would like to get this change merged in, so that we can get off of the discourse specific fork and use the latest version of the image_optim gem. Co-authored-by: Blake Erickson <[email protected]> Do not raise if optimized before timeout Based on feedback this commit includes the following changes: When optimizing multiple images with `optimize_images` a single image timeout doesn't break execution. The global timeout will still raise an exception though if it is reached. When optimizing a single image do not raise an exception if a single worker has succeeded but has reached the timeout period while running through the remaining workers. When optimizing a single image if a single worker times out it will continue on to the next worker until the global timeout is reached.
oblakeerickson
added a commit
to oblakeerickson/image_optim
that referenced
this pull request
Feb 12, 2021
Re-opening the original PR toy#162 and replace PR toy#184 (sorry for multiple PRs). The original commit discourse/image_optim@8bf3c0e on PR toy#162 with just the global timeout has been in production since 2018-07-08 on Discourse instances using a forked version of this gem. We would like to get this change merged in, so that we can get off of the discourse specific fork and use the latest version of the image_optim gem. Add add some more details in the PR discussion. Co-authored-by: Blake Erickson <[email protected]>
oblakeerickson
added a commit
to oblakeerickson/image_optim
that referenced
this pull request
Feb 12, 2021
Re-opening the original PR toy#162 and replacing PR toy#184 (sorry for multiple PRs). The original commit discourse/image_optim@8bf3c0e on PR toy#162 with just the global timeout has been in production since 2018-07-08 on Discourse instances using a forked version of this gem. We would like to get this change merged in, so that we can get off of the discourse specific fork and use the latest version of the image_optim gem. Going to add some more details in the PR discussion. Co-authored-by: Blake Erickson <[email protected]>
okuramasafumi
added a commit
to okuramasafumi/discourse
that referenced
this pull request
Mar 3, 2021
The previous PR toy/image_optim#162 was closed and a new PR toy/image_optim#189 has been submitted.
toy
pushed a commit
that referenced
this pull request
Mar 14, 2021
Re-opening the original PR #162 and replacing PR #184 (sorry for multiple PRs). The original commit discourse/image_optim@8bf3c0e on PR #162 with just the global timeout has been in production since 2018-07-08 on Discourse instances using a forked version of this gem. We would like to get this change merged in, so that we can get off of the discourse specific fork and use the latest version of the image_optim gem. Going to add some more details in the PR discussion. Co-authored-by: Blake Erickson <[email protected]>
toy
pushed a commit
that referenced
this pull request
Mar 19, 2021
Re-opening the original PR #162 and replacing PR #184 (sorry for multiple PRs). The original commit discourse/image_optim@8bf3c0e on PR #162 with just the global timeout has been in production since 2018-07-08 on Discourse instances using a forked version of this gem. We would like to get this change merged in, so that we can get off of the discourse specific fork and use the latest version of the image_optim gem. Going to add some more details in the PR discussion. Co-authored-by: Blake Erickson <[email protected]>
toy
pushed a commit
to oblakeerickson/image_optim
that referenced
this pull request
Apr 28, 2021
Re-opening the original PR toy#162 and replacing PR toy#184 (sorry for multiple PRs). The original commit discourse/image_optim@8bf3c0e on PR toy#162 with just the global timeout has been in production since 2018-07-08 on Discourse instances using a forked version of this gem. We would like to get this change merged in, so that we can get off of the discourse specific fork and use the latest version of the image_optim gem. Going to add some more details in the PR discussion. Co-authored-by: Blake Erickson <[email protected]>
toy
pushed a commit
to oblakeerickson/image_optim
that referenced
this pull request
May 9, 2021
Re-opening the original PR toy#162 and replacing PR toy#184 (sorry for multiple PRs). The original commit discourse/image_optim@8bf3c0e on PR toy#162 with just the global timeout has been in production since 2018-07-08 on Discourse instances using a forked version of this gem. We would like to get this change merged in, so that we can get off of the discourse specific fork and use the latest version of the image_optim gem. Going to add some more details in the PR discussion. Co-authored-by: Blake Erickson <[email protected]>
toy
pushed a commit
to oblakeerickson/image_optim
that referenced
this pull request
May 9, 2021
The original commit discourse/image_optim@8bf3c0e, see discussion in resolved PRs. Resolves toy#21, resolves toy#148, resolves toy#149, resolves toy#162, resolves toy#184, resolves toy#189. Co-authored-by: Blake Erickson <[email protected]>
toy
added a commit
to oblakeerickson/image_optim
that referenced
this pull request
May 9, 2021
The original commit discourse/image_optim@8bf3c0e, see discussion in resolved PRs. Resolves toy#21, resolves toy#148, resolves toy#149, resolves toy#162, resolves toy#184, resolves toy#189. Co-authored-by: Blake Erickson <[email protected]> Co-authored-by: Ivan Kuchin <[email protected]>
toy
added a commit
that referenced
this pull request
May 9, 2021
The original commit discourse/image_optim@8bf3c0e, see discussion in resolved PRs. Resolves #21, resolves #148, resolves #149, resolves #162, resolves #184, resolves #189. Co-authored-by: Blake Erickson <[email protected]> Co-authored-by: Ivan Kuchin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.