Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow workers to timeout. #148

Closed
wants to merge 1 commit into from
Closed

Conversation

tgxworld
Copy link
Contributor

#21

@tgxworld
Copy link
Contributor Author

cc @SamSaffron

@tgxworld tgxworld force-pushed the implement_timeout branch 10 times, most recently from caea3e8 to e2e87bc Compare April 17, 2017 09:00
@tgxworld tgxworld force-pushed the implement_timeout branch from e2e87bc to 2cccdf6 Compare April 17, 2017 09:01
@tgxworld
Copy link
Contributor Author

@toy Would you prefer to have the timeout option passed to optimize_image or optimize_image! instead?

Also, I'm having trouble getting the tests to pass on JRuby as it might be related to
jruby/jruby#2684. Would love to have some help here.

@tgxworld
Copy link
Contributor Author

Hmm I'm trying to think of another way to do this without Timeout.timeout. Will have a think about it.

@tgxworld tgxworld closed this Apr 17, 2017
@toy
Copy link
Owner

toy commented Apr 17, 2017

@tgxworld I was late to reply while it was open. Anyway nice and thanks for contribution.
I would prefer a global config exactly as you did. Maybe even better to allow it to be set also per worker somewhat like for allow_lossy, some tools tend to be more time hungry than others, so setting global timeout to for example 30 seconds and timeout for some specific worker to 300 seconds.
Don't forget to add an entry to changelog and add the option to cli options and readme.

toy pushed a commit to oblakeerickson/image_optim that referenced this pull request May 9, 2021
The original commit discourse/image_optim@8bf3c0e, see discussion in resolved PRs.

Resolves toy#21, resolves toy#148, resolves toy#149, resolves toy#162, resolves toy#184, resolves toy#189.

Co-authored-by: Blake Erickson <[email protected]>
toy added a commit to oblakeerickson/image_optim that referenced this pull request May 9, 2021
The original commit discourse/image_optim@8bf3c0e, see discussion in resolved PRs.

Resolves toy#21, resolves toy#148, resolves toy#149, resolves toy#162, resolves toy#184, resolves toy#189.

Co-authored-by: Blake Erickson <[email protected]>
Co-authored-by: Ivan Kuchin <[email protected]>
toy added a commit that referenced this pull request May 9, 2021
The original commit discourse/image_optim@8bf3c0e, see discussion in resolved PRs.

Resolves #21, resolves #148, resolves #149, resolves #162, resolves #184, resolves #189.

Co-authored-by: Blake Erickson <[email protected]>
Co-authored-by: Ivan Kuchin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants