config: Revert removal of {packages}/{opts} hack #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem identified in tox-dev#1777
This was removed in e4d0d60, and replaced with a neater approach, however the newer approach doesnt work for replacements from other sections. Fixes tox-dev#1777
jayvdb
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
jayvdb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1777
Re-submitting #1794 which appears to be lost after merging.
Also I suspect the auto-closing didnt work, and I see now that is because the two commits with specific messages were merged into a single commit using the GitHub merge features.