Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial revert of e4d0d600, fixing #1777 #1794

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Partial revert of e4d0d600, fixing #1777 #1794

merged 2 commits into from
Jan 11, 2021

Conversation

jayvdb
Copy link

@jayvdb jayvdb commented Jan 11, 2021

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

jayvdb added 2 commits January 11, 2021 09:00
@jayvdb
test_config: Add test for indirect install_command
f524cef 
Problem identified in tox-dev#1777
@jayvdb
config: Revert removal of {packages}/{opts} hack
352bedc 
This was removed in e4d0d60, and replaced with a
neater approach, however the newer approach doesnt
work for replacements from other sections.

Fixes tox-dev#1777
gaborbernat
gaborbernat approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit da140fb into tox-dev:master Jan 11, 2021
@jayvdb jayvdb mentioned this pull request Jan 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

@asottile asottile Awaiting requested review from asottile

@obestwalter obestwalter Awaiting requested review from obestwalter

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayvdb @gaborbernat