Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure pipeline restructure and migration to codeclimate #1025

Closed
wants to merge 1 commit into from
Closed

azure pipeline restructure and migration to codeclimate #1025

wants to merge 1 commit into from

Conversation

gaborbernat
Copy link
Member

👍 Resolves #1024.

nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Oct 1, 2018
@nicoddemus
Issue warning if Monkeypatch.setenv/delenv receive non-strings in Pyt…
d24a7e6 
…hon 2

Fixes the bug described in:

	tox-dev/tox#1025 (comment)

Which is more evident when using `unicode_literals`.
@gaborbernat
Copy link
Member Author

Eh, feels like we got hit by:

Yes publishing artifacts from fork builds is currently blocked as we did not have a way to given a sufficiently scoped token to the agent. This is something we are working on fixing but it is going to be a few weeks.

https://github.com/Linuxbrew/brew/issues/746#issuecomment-422955300

@anthrotype
Copy link

Just curious, why the switch from codecov to coveralls?

@anthrotype
Copy link

just saw your comment #1028 (comment)

Seems codecov does not support Azure DevOps

Pity

@gaborbernat
Copy link
Member Author

@anthrotype furthermore codecov turned out to be really flaky for us in the last few months (many unexplainable results) and we got no support when reaching out to them. ``coveralls` also does not implicitly supports it but at least their API is somehow easier to integrate at some level.

@gaborbernat gaborbernat force-pushed the master branch 11 times, most recently from 82893ab to 8c1a29f Compare October 3, 2018 16:32
@gaborbernat gaborbernat changed the title [wip] azure pipeline restructure and migration from codecov to coveralls azure pipeline restructure and migration to codeclimate Oct 3, 2018
@gaborbernat
Copy link
Member Author

Closing in favour of #1031; I've kept this option only to validate that PR-ing from a fork still works correctly (although no global coverage report). Once Azure Pipelines offers artifact uploads for forks (ETA around 3 weeks), we'll enable coverage generation on all branches. Note in case Azure Pipelines would not deliver this we can migrate to storing the coverage artifacts on Amazon S3 (for a very small cost probably).

@gaborbernat gaborbernat closed this Oct 3, 2018
@gaborbernat gaborbernat mentioned this pull request Oct 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus left review comments

@obestwalter obestwalter obestwalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaborbernat @obestwalter @anthrotype @nicoddemus