Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI #85

Closed
wants to merge 8 commits into from
Closed

Add CI #85

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6005244
Add CI
inverse Sep 22, 2021
d68c7c0
Simplify trigger
inverse Sep 22, 2021
1f3b766
Remove poetry cp
inverse Sep 22, 2021
6b7005e
Add more python versions
inverse Sep 22, 2021
6b6aedc
Update .github/workflows/ci.yml
inverse Sep 22, 2021
2ade1ad
Update .github/workflows/ci.yml
inverse Sep 22, 2021
ca6eccb
Update .github/workflows/ci.yml
inverse Sep 22, 2021
faf040c
Update .github/workflows/ci.yml
inverse Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: CI

on: [push, pull_request]

inverse marked this conversation as resolved.
Show resolved Hide resolved
jobs:
test:
strategy:
matrix:
python-version: ["3.10-dev", "3.9", "3.8", "3.7", "3.6"]
os: [macos-latest, windows-latest, ubuntu-latest]
runs-on: ${{ matrix.os }}
env:
IS_COVERAGE_ALLOWED: ${{ secrets.CODACY_PROJECT_TOKEN != '' }}
IS_MASTER_BRANCH: ${{ github.ref == 'refs/heads/master' }}
steps:
- uses: actions/checkout@master
- uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Install pip dependencies
run: pip install -r requirements-test.txt
- name: Test
run: pytest -v test.py
Comment on lines +22 to +25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it would be better to add a test extra and do pip install .[test].

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,5 @@ nosetests.xml
docs/build

test.lock

/.venv/
1 change: 1 addition & 0 deletions requirements-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
pytest==6.2.5
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poetry might make more sense long term for managing/packaging this but went with plain pip for now to be easier :)