Add CI #85
Closed
Add CI #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
inverse
commented
Sep 22, 2021
| @@ -0,0 +1 @@ | |||
| pytest==6.2.5 | |||
There was a problem hiding this comment.
Poetry might make more sense long term for managing/packaging this but went with plain pip for now to be easier :)
inverse
commented
Sep 22, 2021
.github/workflows/ci.yml
Outdated
| test: | ||
| strategy: | ||
| matrix: | ||
| python-version: [3.9] |
There was a problem hiding this comment.
Could be extended to the other versions of Python needed to be supported.
hugovk
approved these changes
Sep 22, 2021
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
|
Thanks for the feedback @hugovk! Example run: https://github.com/inverse/py-filelock/actions/runs/1262174438 |
hugovk
reviewed
Sep 22, 2021
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
approved these changes
Sep 22, 2021
FFY00
reviewed
Sep 22, 2021
Comment on lines
+22
to
+25
| - name: Install pip dependencies | ||
| run: pip install -r requirements-test.txt | ||
| - name: Test | ||
| run: pytest -v test.py |
There was a problem hiding this comment.
IMO it would be better to add a test extra and do pip install .[test].
|
This has been done in #87, thanks for the contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: https://github.com/inverse/py-filelock/actions/runs/1262174438