You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm one of the maintainers of webargs (https://github.com/marshmallow-code/webargs), and we've had some CI failures start cropping up in the last couple of days related to our tornado support tests. When I start looking in detail, I see that tornado hasn't released in the very recent past, but pytest has, and that the issue appears to be tied to pytest's recent 8.2.0 release.
I have some more detail, in the webargs context, written up over here: marshmallow-code/webargs#941
All I really have so far is that test collection fails with this trace:
____________________ ERROR collecting tests/test_tornadoparser.py ____________________
.tox/py311/lib/python3.11/site-packages/tornado/testing.py:180: in __init__
setattr(self, methodName, _TestMethodWrapper(getattr(self, methodName)))
E AttributeError: 'AsyncHTTPTestCase' object has no attribute 'runTest'
____________________ ERROR collecting tests/test_tornadoparser.py ____________________
.tox/py311/lib/python3.11/site-packages/tornado/testing.py:180: in __init__
setattr(self, methodName, _TestMethodWrapper(getattr(self, methodName)))
E AttributeError: 'TestApp' object has no attribute 'runTest'
____________________ ERROR collecting tests/test_tornadoparser.py ____________________
.tox/py311/lib/python3.11/site-packages/tornado/testing.py:180: in __init__
setattr(self, methodName, _TestMethodWrapper(getattr(self, methodName)))
E AttributeError: 'TestValidateApp' object has no attribute 'runTest'
and that downgrading pytest to 8.1.2 fixes it.
Apologies if this turns out to be a problem with my usage, or a pytest issue (rather than a tornado one), but I wanted to raise it here for visibility.
The text was updated successfully, but these errors were encountered:
Overriding _callTestMethod (which was introduced in python 3.8) is a
less hacky way to detect tests that fail to use ``@gen_test`` where
needed. It's not documented, but since Python 3.11 has introduced a
similar check to the standard library we'll be able to remove it in the
near future.
The major impetus for this change is an incompatibility with
Pytest 8.2, which has made a change that tries to instantiate test
classes at discovery time without an existing method name.
Fixestornadoweb#3375Closestornadoweb#3374
I'm one of the maintainers of webargs (https://github.com/marshmallow-code/webargs), and we've had some CI failures start cropping up in the last couple of days related to our tornado support tests. When I start looking in detail, I see that tornado hasn't released in the very recent past, but pytest has, and that the issue appears to be tied to pytest's recent 8.2.0 release.
I have some more detail, in the webargs context, written up over here: marshmallow-code/webargs#941
All I really have so far is that test collection fails with this trace:
and that downgrading pytest to 8.1.2 fixes it.
Apologies if this turns out to be a problem with my usage, or a pytest issue (rather than a tornado one), but I wanted to raise it here for visibility.
The text was updated successfully, but these errors were encountered: