motioneye_init: stop and disable conflicting motion.service #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motion package installs a motion systemd service, which can block camera devices and hence conflict with the motionEye-controlled motion processes. We hence need to assure that this service is stopped and disabled, before we can start and enable out motioneye.service. Signed-off-by: MichaIng <[email protected]>
Signed-off-by: MichaIng <[email protected]>
I am not sure why this test suddenly runs into errors, on a totally unrelated (no Python code) commit. I guess pytest or some dependency god a breaking update. The log talks about non-defined runTest method, which is the default method called by tornado.test classes. But I think the underlying issue is some incompatible variables types, see mypy test errors (which we ignore as well). I hope someone with pytest experience can look into it. Probably those tests should be built up from scratch anyway. Until then, we ignore the errors, like we do for MJPEG and RTMP tests already. Signed-off-by: MichaIng <[email protected]>
|
If someone is able to identify the issue with the |
There is no point to test on different Ubuntu versions, when we use the same Python version on all of them. Use the Python version that is used on the respective Ubuntu version explicitly. The runners ship with the same minor version (3.8, 3.10 etc), but with more recent patch versions than provided by the Ubuntu APT repositories. Signed-off-by: MichaIng <[email protected]>
|
I wonder if the test failure is related to this: tornadoweb/tornado#3374 At least downgrading pytest to 8.1.2 as mentioned here seems to fix the issue. |
zagrim
approved these changes
May 11, 2024
|
Great find, yes that will be it. I subscribed to the PR and will un-ignore the tests, once it was merged and released. |
This was referenced May 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motion package installs a motion systemd service, which can block camera devices and hence conflict with the motionEye-controlled motion processes.
We hence need to assure that this service is stopped and disabled, before we can start and enable our motioneye.service.
See #2810 (comment), #2816 and other cases.