Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: workflow to publish prebuilt ld and binutils #68

Closed
wants to merge 8 commits into from

Conversation

crazy-max
Copy link
Collaborator

@crazy-max crazy-max commented May 10, 2022

needs #114

Adds workflows to publish prebuilt ld and binutils using a dynamic matrix based on grouped bake targets to distribute the workload over several runners.

It will only build on push on master. To create a new release the workflow needs to be triggered manually:

image

Git tag will be in the form:

  • binutils/2.36.1-5 (where 5 is the run number for the workflow ; unique)
  • prebuilt/ld-2.36.1-8 (where 8 is the run number for the workflow ; unique)

Test prebuilt ld:

Test binutils:

@crazy-max crazy-max marked this pull request as draft May 10, 2022 14:03
@crazy-max crazy-max force-pushed the gha-prebuilt-ld branch 2 times, most recently from b2295f7 to 2712e73 Compare May 10, 2022 15:22
@crazy-max

This comment was marked as outdated.

@crazy-max crazy-max marked this pull request as ready for review May 10, 2022 15:23
@crazy-max crazy-max requested a review from tonistiigi May 10, 2022 15:24
@crazy-max crazy-max force-pushed the gha-prebuilt-ld branch 2 times, most recently from 045b12a to ec2a701 Compare January 26, 2023 14:48
Copy link
Owner

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to split up all the ld targets to separate Dockerfile inside a subdirectory. Then we can make this workflow so that it runs only if files inside the subdirectory change. If it is simple, we can also set up some bot that would allow to trigger the additional CI on-demand.

For the release, we do not need to release this very often. It shouldn't be on every master branch change. The method we use in binfmt is quite nice to trigger it from manual form and then also create a tag for the deployment.

Note that releasing new binaries does not change xx. The digests need to be updated manually later on. If this isn't implemented already the release should generate a file with all the digests so it can be easily copied to the scripts (or we could keep it in a separate file as well and modify script to link it).

docker-bake.hcl Outdated
output = ["./ld64-tgz"]
}

target "ld64-linux-amd64-tgz" {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these separate targets in here. ld64-tgz already builds all combinations.

Copy link
Collaborator Author

@crazy-max crazy-max Feb 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to reduce build time so we can distribute builds across multi runners in the pipeline, see: https://github.com/crazy-max/xx/actions/runs/4155296585

.github/workflows/prebuilt-ld.yml Outdated Show resolved Hide resolved
@crazy-max
Copy link
Collaborator Author

Note that releasing new binaries does not change xx. The digests need to be updated manually later on. If this isn't implemented already the release should generate a file with all the digests so it can be easily copied to the scripts (or we could keep it in a separate file as well and modify script to link it).

Yes indeed, I have another branch that would update shas and open a pull request with new sums: master...crazy-max:xx:binutils-2.38#diff-ee26bbfc163346b915c6c9c65709c15b58251a23a0d9ecaaed6d2d20f969fb92R96-R148

@crazy-max
Copy link
Collaborator Author

For the release, we do not need to release this very often. It shouldn't be on every master branch change. The method we use in binfmt is quite nice to trigger it from manual form and then also create a tag for the deployment.

Agree, will change this.

@crazy-max crazy-max force-pushed the gha-prebuilt-ld branch 2 times, most recently from 645de7b to 2bcfb1c Compare February 12, 2023 09:00
@crazy-max
Copy link
Collaborator Author

Updated, see PR description

@crazy-max crazy-max requested a review from tonistiigi February 12, 2023 09:09
@crazy-max crazy-max force-pushed the gha-prebuilt-ld branch 8 times, most recently from 1df70ec to 929012d Compare February 12, 2023 17:34
@crazy-max crazy-max force-pushed the gha-prebuilt-ld branch 2 times, most recently from 3b26f89 to 489e092 Compare February 13, 2023 20:00
@crazy-max
Copy link
Collaborator Author

rebased and needs #114

@crazy-max crazy-max force-pushed the gha-prebuilt-ld branch 3 times, most recently from 908178b to ff863e6 Compare July 13, 2023 15:59
@crazy-max crazy-max closed this Jan 12, 2024
@crazy-max crazy-max deleted the gha-prebuilt-ld branch January 12, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants