Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ld64 matrix build #114

Merged
merged 6 commits into from
Jul 24, 2023
Merged

ld64 matrix build #114

merged 6 commits into from
Jul 24, 2023

Conversation

crazy-max
Copy link
Collaborator

No description provided.

@crazy-max crazy-max requested a review from tonistiigi July 13, 2023 11:45
@crazy-max crazy-max marked this pull request as ready for review July 13, 2023 11:45
@crazy-max crazy-max mentioned this pull request Jul 13, 2023
Closed
tonistiigi
tonistiigi reviewed Jul 13, 2023
View reviewed changes
Copy link
Owner

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, we can also simplify this a lot by adding a matrix in the HCL.

@crazy-max crazy-max force-pushed the ld64-static-tgz branch 2 times, most recently from fb64471 to 56731f9 Compare July 15, 2023 03:00
@crazy-max crazy-max requested a review from jedevc July 24, 2023 12:39
@crazy-max crazy-max merged commit db72d58 into tonistiigi:master Jul 24, 2023
@crazy-max crazy-max deleted the ld64-static-tgz branch July 24, 2023 13:57
@crazy-max crazy-max mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi left review comments

@jedevc jedevc jedevc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crazy-max @tonistiigi @jedevc